Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3398)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: cc/surfaces/surface_info.h

Issue 2848223003: Enforce constant size and device scale factor for surfaces (Closed)
Patch Set: c Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« cc/surfaces/surface.cc ('K') | « cc/surfaces/surface_aggregator_unittest.cc ('k') | cc/surfaces/surface_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/surfaces/surface_info.h
diff --git a/cc/surfaces/surface_info.h b/cc/surfaces/surface_info.h
index 14cfab554b360cb443be4bd50b018277743b040b..1a39becc3c1d1b407da25f23c005037eae27424d 100644
--- a/cc/surfaces/surface_info.h
+++ b/cc/surfaces/surface_info.h
@@ -29,10 +29,7 @@ class SurfaceInfo {
device_scale_factor_(device_scale_factor),
size_in_pixels_(size_in_pixels) {}
- bool is_valid() const {
- return id_.is_valid() && device_scale_factor_ != 0 &&
- !size_in_pixels_.IsEmpty();
- }
+ bool is_valid() const { return id_.is_valid(); }
Fady Samuel 2017/05/08 20:21:19 Why?
Saman Sami 2017/05/08 20:40:32 I need to fix some tests that clash with the origi
bool operator==(const SurfaceInfo& info) const {
return id_ == info.id() &&
« cc/surfaces/surface.cc ('K') | « cc/surfaces/surface_aggregator_unittest.cc ('k') | cc/surfaces/surface_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698