Enforce constant size and device scale factor for surfaces

cc/test/compositor_frame_helpers.cc

Index: cc/test/compositor_frame_helpers.cc
diff --git a/cc/test/compositor_frame_helpers.cc b/cc/test/compositor_frame_helpers.cc
index 33e0ed63a1ee22d8b73dc58bb2dba0b61f4ea885..73451ab566a560bc195ee328d561d7a816fefd22 100644
--- a/cc/test/compositor_frame_helpers.cc
+++ b/cc/test/compositor_frame_helpers.cc
@@ -22,6 +22,7 @@ CompositorFrame MakeEmptyCompositorFrame() {
   frame.metadata.begin_frame_ack.source_id = BeginFrameArgs::kManualSourceId;
   frame.metadata.begin_frame_ack.sequence_number =
       BeginFrameArgs::kStartingFrameNumber;
+  frame.metadata.begin_frame_ack.has_damage = true;

[danakj, 2017/05/18 15:15:54]

Why is this needed? Any why not needed in the other functions?

[Saman Sami, 2017/05/18 20:44:37]

The other methods call this method internally. CFSS::SubmitCompositorFrame
dchecks that has_damage is true.

[danakj, 2017/05/19 19:00:59]

It seems that CFSS is setting has_damage, not dchecking it?

// |has_damage| is not transmitted.
frame.metadata.begin_frame_ack.has_damage = true;

[Saman Sami, 2017/05/19 19:26:46]

Oops. It was DirectCFS that dchecked. I used this method in DirectCFS tests and
I added this line so it doesn't fail.

[danakj, 2017/05/19 19:31:39]

I see, thanks.

   frame.metadata.device_scale_factor = 1;
   return frame;
 }