Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1452)

Unified Diff: net/tools/quic/end_to_end_test.cc

Issue 2848203002: Add a platform implementation of QuicTest and QuicTestWithParam (Closed)
Patch Set: net/quic/platform/impl/quic_test_impl.cc Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/quic/chlo_extractor_test.cc ('k') | net/tools/quic/platform/impl/quic_epoll_clock_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/end_to_end_test.cc
diff --git a/net/tools/quic/end_to_end_test.cc b/net/tools/quic/end_to_end_test.cc
index 255d1b722e0b737743183ed9d3d5a621501a363d..8e0a816be123b6a428b09d0e0f9dab399adb9d2b 100644
--- a/net/tools/quic/end_to_end_test.cc
+++ b/net/tools/quic/end_to_end_test.cc
@@ -34,6 +34,7 @@
#include "net/quic/platform/api/quic_socket_address.h"
#include "net/quic/platform/api/quic_str_cat.h"
#include "net/quic/platform/api/quic_string_piece.h"
+#include "net/quic/platform/api/quic_test.h"
#include "net/quic/platform/api/quic_text_utils.h"
#include "net/quic/test_tools/crypto_test_utils.h"
#include "net/quic/test_tools/quic_config_peer.h"
@@ -293,7 +294,7 @@ class ClientDelegate : public PacketDroppingTestWriter::Delegate {
QuicClient* client_;
};
-class EndToEndTest : public ::testing::TestWithParam<TestParams> {
+class EndToEndTest : public QuicTestWithParam<TestParams> {
protected:
EndToEndTest()
: initialized_(false),
@@ -602,7 +603,6 @@ class EndToEndTest : public ::testing::TestWithParam<TestParams> {
stream_factory_ = factory;
}
- QuicFlagSaver flags_; // Save/restore all QUIC flag values.
bool initialized_;
QuicSocketAddress server_address_;
string server_hostname_;
« no previous file with comments | « net/tools/quic/chlo_extractor_test.cc ('k') | net/tools/quic/platform/impl/quic_epoll_clock_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698