Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Unified Diff: net/quic/core/quic_server_id_test.cc

Issue 2848203002: Add a platform implementation of QuicTest and QuicTestWithParam (Closed)
Patch Set: net/quic/platform/impl/quic_test_impl.cc Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_sent_packet_manager_test.cc ('k') | net/quic/core/quic_server_session_base_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_server_id_test.cc
diff --git a/net/quic/core/quic_server_id_test.cc b/net/quic/core/quic_server_id_test.cc
index 95eeb670f3c8f5f6eea2ff9f598f662700006c8b..abf05a3edd4230e4aeaa12c9206656a9d2501f48 100644
--- a/net/quic/core/quic_server_id_test.cc
+++ b/net/quic/core/quic_server_id_test.cc
@@ -4,7 +4,7 @@
#include "net/quic/core/quic_server_id.h"
-#include "testing/gtest/include/gtest/gtest.h"
+#include "net/quic/platform/api/quic_test.h"
using std::string;
@@ -12,7 +12,9 @@ namespace net {
namespace {
-TEST(QuicServerIdTest, ToString) {
+class QuicServerIdTest : public QuicTest {};
+
+TEST_F(QuicServerIdTest, ToString) {
HostPortPair google_host_port_pair("google.com", 10);
QuicServerId google_server_id(google_host_port_pair, PRIVACY_MODE_DISABLED);
@@ -24,7 +26,7 @@ TEST(QuicServerIdTest, ToString) {
EXPECT_EQ("https://google.com:10/private", private_server_id_str);
}
-TEST(QuicServerIdTest, LessThan) {
+TEST_F(QuicServerIdTest, LessThan) {
QuicServerId a_10_https(HostPortPair("a.com", 10), PRIVACY_MODE_DISABLED);
QuicServerId a_11_https(HostPortPair("a.com", 11), PRIVACY_MODE_DISABLED);
QuicServerId b_10_https(HostPortPair("b.com", 10), PRIVACY_MODE_DISABLED);
@@ -86,7 +88,7 @@ TEST(QuicServerIdTest, LessThan) {
}
}
-TEST(QuicServerIdTest, Equals) {
+TEST_F(QuicServerIdTest, Equals) {
PrivacyMode left_privacy;
PrivacyMode right_privacy;
for (int i = 0; i < 2; i++) {
« no previous file with comments | « net/quic/core/quic_sent_packet_manager_test.cc ('k') | net/quic/core/quic_server_session_base_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698