Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: net/quic/core/quic_sent_packet_manager_test.cc

Issue 2848203002: Add a platform implementation of QuicTest and QuicTestWithParam (Closed)
Patch Set: net/quic/platform/impl/quic_test_impl.cc Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_received_packet_manager_test.cc ('k') | net/quic/core/quic_server_id_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_sent_packet_manager_test.cc
diff --git a/net/quic/core/quic_sent_packet_manager_test.cc b/net/quic/core/quic_sent_packet_manager_test.cc
index f8b37581c1a3968a378f44866ffcf19c00630c7a..6aa1015efeb6a71fcdd71804739166161cb27791 100644
--- a/net/quic/core/quic_sent_packet_manager_test.cc
+++ b/net/quic/core/quic_sent_packet_manager_test.cc
@@ -10,11 +10,10 @@
#include "net/quic/platform/api/quic_flags.h"
#include "net/quic/platform/api/quic_ptr_util.h"
#include "net/quic/platform/api/quic_string_piece.h"
+#include "net/quic/platform/api/quic_test.h"
#include "net/quic/test_tools/quic_config_peer.h"
#include "net/quic/test_tools/quic_sent_packet_manager_peer.h"
#include "net/quic/test_tools/quic_test_utils.h"
-#include "testing/gmock/include/gmock/gmock.h"
-#include "testing/gtest/include/gtest/gtest.h"
using testing::AnyNumber;
using testing::ElementsAre;
@@ -56,7 +55,7 @@ class MockDebugDelegate : public QuicSentPacketManager::DebugDelegate {
QuicTime detection_time));
};
-class QuicSentPacketManagerTest : public ::testing::Test {
+class QuicSentPacketManagerTest : public QuicTest {
protected:
QuicSentPacketManagerTest()
: manager_(Perspective::IS_SERVER, &clock_, &stats_, kCubicBytes, kNack),
@@ -270,7 +269,6 @@ class QuicSentPacketManagerTest : public ::testing::Test {
frame->packets.Remove(lower, higher);
}
- QuicFlagSaver flags_; // Save/restore all QUIC flag values.
QuicSentPacketManager manager_;
MockClock clock_;
QuicConnectionStats stats_;
« no previous file with comments | « net/quic/core/quic_received_packet_manager_test.cc ('k') | net/quic/core/quic_server_id_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698