Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: net/quic/core/crypto/common_cert_set_test.cc

Issue 2848203002: Add a platform implementation of QuicTest and QuicTestWithParam (Closed)
Patch Set: net/quic/platform/impl/quic_test_impl.cc Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/crypto/channel_id_test.cc ('k') | net/quic/core/crypto/crypto_framer_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/crypto/common_cert_set_test.cc
diff --git a/net/quic/core/crypto/common_cert_set_test.cc b/net/quic/core/crypto/common_cert_set_test.cc
index 85bc74b2341d53d0539c1a5a659fff4525b02dd3..316657d50290bc28c786ffbd19a8978432be2890 100644
--- a/net/quic/core/crypto/common_cert_set_test.cc
+++ b/net/quic/core/crypto/common_cert_set_test.cc
@@ -6,7 +6,7 @@
#include <cstdint>
-#include "testing/gtest/include/gtest/gtest.h"
+#include "net/quic/platform/api/quic_test.h"
namespace net {
namespace test {
@@ -189,7 +189,9 @@ static const unsigned char kGIACertificate3[] = {
0xc1, 0x21, 0xc6, 0x16,
};
-TEST(CommonCertSets, FindGIA_2) {
+class CommonCertSetsTest : public QuicTest {};
+
+TEST_F(CommonCertSetsTest, FindGIA_2) {
QuicStringPiece gia(reinterpret_cast<const char*>(kGIACertificate2),
sizeof(kGIACertificate2));
@@ -210,7 +212,7 @@ TEST(CommonCertSets, FindGIA_2) {
EXPECT_EQ(0, memcmp(gia.data(), gia_copy.data(), gia.size()));
}
-TEST(CommonCertSets, FindGIA_3) {
+TEST_F(CommonCertSetsTest, FindGIA_3) {
QuicStringPiece gia(reinterpret_cast<const char*>(kGIACertificate3),
sizeof(kGIACertificate3));
@@ -231,7 +233,7 @@ TEST(CommonCertSets, FindGIA_3) {
EXPECT_EQ(0, memcmp(gia.data(), gia_copy.data(), gia.size()));
}
-TEST(CommonCertSets, NonMatch) {
+TEST_F(CommonCertSetsTest, NonMatch) {
const CommonCertSets* sets(CommonCertSets::GetInstanceQUIC());
QuicStringPiece not_a_cert("hello");
const uint64_t in_hash = UINT64_C(0xc9fef74053f99f39);
« no previous file with comments | « net/quic/core/crypto/channel_id_test.cc ('k') | net/quic/core/crypto/crypto_framer_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698