Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2848153002: fix #29504, dcall on object member when a temporary was involved. (Closed)

Created:
3 years, 7 months ago by Jennifer Messerly
Modified:
3 years, 7 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix #29504, dcall on object member when a temporary was involved. R=vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/c305d183c3f217dd5cfe9a6c5171cbe0313ee586

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -5 lines) Patch
M pkg/dev_compiler/lib/src/compiler/code_generator.dart View 4 chunks +8 lines, -5 lines 0 comments Download
A tests/language_strong/dynamic_invoke_test.dart View 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jennifer Messerly
3 years, 7 months ago (2017-04-29 00:50:27 UTC) #2
vsm
lgtm
3 years, 7 months ago (2017-04-29 03:06:17 UTC) #3
Jennifer Messerly
3 years, 7 months ago (2017-05-01 17:58:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c305d183c3f217dd5cfe9a6c5171cbe0313ee586 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698