Move test.dart into testing/dart.

Move test.dart into testing/dart.

This is mainly so that all of the code relating to test.dart is in one
directory tree so things like "Find All Usages" work a little better.
It felt weird to me to have a .dart file two directories up importing a
bunch of stuff within "testing/dart/".

Also cleaned up the affected code since it could use a little love. I'm
working on getting test.dart running DDC tests, but from poking around,
it seems like it could use some housekeeping as well.

R=vsm@google.com, whesse@google.com

Committed: https://github.com/dart-lang/sdk/commit/53b2ef34caf5d79d4f362408954edb6ad14ecf32

[Bob Nystrom, 2017-04-28 22:32:20]

rnystrom@google.com changed reviewers:
+ whesse@google.com

[Bob Nystrom, 2017-04-28 22:32:21]

Trying to do a little maintenance and upkeep on test.dart before I pour more
code in to get it running DDC tests.

(Also, minor refactoring like this helps me learn my way around it.)

[vsm, 2017-05-01 22:44:20]

vsm@google.com changed reviewers:
+ vsm@google.com

[vsm, 2017-05-01 22:44:21]

lgtm - but i'm not that familiar with this code

[Bill Hesse, 2017-05-02 14:33:09]

lgtm

https://codereview.chromium.org/2848103002/diff/1/tools/testing/dart/main.dart
File tools/testing/dart/main.dart (right):

https://codereview.chromium.org/2848103002/diff/1/tools/testing/dart/main.dar...
tools/testing/dart/main.dart:38: LeftOverTempDirPrinter.deleteAll();
I see that this has become a sync call, so OK.

https://codereview.chromium.org/2848103002/diff/1/tools/testing/dart/test_pro...
File tools/testing/dart/test_progress.dart (right):

https://codereview.chromium.org/2848103002/diff/1/tools/testing/dart/test_pro...
tools/testing/dart/test_progress.dart:544: void allDone() {
Could you try to locally test this code, by adding a test that creates 100 temp
directories?  And is it really true, about tempdir- and temp_dir1_ ?

[Bob Nystrom, 2017-05-02 23:48:15]

Thanks!

https://codereview.chromium.org/2848103002/diff/1/tools/testing/dart/main.dart
File tools/testing/dart/main.dart (right):

https://codereview.chromium.org/2848103002/diff/1/tools/testing/dart/main.dar...
tools/testing/dart/main.dart:38: LeftOverTempDirPrinter.deleteAll();
On 2017/05/02 14:33:08, Bill Hesse wrote:
> I see that this has become a sync call, so OK.

Yup. I didn't see much benefit to making it async. (Anecdotally, my experience
has been that sync dart:io is often faster than async.) Either way, this isn't
exactly performance critical in the very common case where there are no temp
directories.

https://codereview.chromium.org/2848103002/diff/1/tools/testing/dart/test_pro...
File tools/testing/dart/test_progress.dart (right):

https://codereview.chromium.org/2848103002/diff/1/tools/testing/dart/test_pro...
tools/testing/dart/test_progress.dart:544: void allDone() {
On 2017/05/02 14:33:09, Bill Hesse wrote:
> Could you try to locally test this code, by adding a test that creates 100
temp
> directories?  And is it really true, about tempdir- and temp_dir1_ ?

Uh, now that you mention it, no, it does not seem to be true. On my Mac, if I
call:

  print(Directory.systemTemp.createTempSync().path);

I get something like:

  /var/folders/vw/b46gfymx10ddqfg1m_tr72sw003cg5/T/hLqmvN

No "tempdir1" prefix at all. Likewise if I pass a prefix to createTempSync(), I
get:

  /var/folders/vw/b46gfymx10ddqfg1m_tr72sw003cg5/T/prefixcZM6RZ

Looks like the hardcoded "temp_dir" prefixes have been gone since 2013
(https://github.com/dart-lang/sdk/commit/b221c702a3db269e3db91ad88be205e0bcb48...
I'll remove this code completely.

[Bob Nystrom, 2017-05-02 23:48:31]

Description was changed from

==========
Move test.dart into testing/dart.

This is mainly so that all of the code relating to test.dart is in one
directory tree so things like "Find All Usages" work a little better.
It felt weird to me to have a .dart file two directories up importing a
bunch of stuff within "testing/dart/".

Also cleaned up the affected code since it could use a little love. I'm
working on getting test.dart running DDC tests, but from poking around,
it seems like it could use some housekeeping as well.
==========

to

==========
Move test.dart into testing/dart.

This is mainly so that all of the code relating to test.dart is in one
directory tree so things like "Find All Usages" work a little better.
It felt weird to me to have a .dart file two directories up importing a
bunch of stuff within "testing/dart/".

Also cleaned up the affected code since it could use a little love. I'm
working on getting test.dart running DDC tests, but from poking around,
it seems like it could use some housekeeping as well.

R=vsm@google.com, whesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/53b2ef34caf5d79d4f362408954edb6ad14ecf32
==========

[Bob Nystrom, 2017-05-02 23:48:32]

Committed patchset #2 (id:20001) manually as
53b2ef34caf5d79d4f362408954edb6ad14ecf32 (presubmit successful).