Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3438)

Unified Diff: chrome/test/data/webui/print_preview_destination_search_test.js

Issue 2848093002: Process null capabilities as a capability fetch failure. (Closed)
Patch Set: address comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/print_preview/print_preview_handler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/print_preview_destination_search_test.js
diff --git a/chrome/test/data/webui/print_preview_destination_search_test.js b/chrome/test/data/webui/print_preview_destination_search_test.js
index 2155bd7820beb4ff844b9bbad2fb318f5ba96494..fdba0e14b3ac328ee0a828a4bf69dea2a570a660 100644
--- a/chrome/test/data/webui/print_preview_destination_search_test.js
+++ b/chrome/test/data/webui/print_preview_destination_search_test.js
@@ -196,7 +196,6 @@ TEST_F('PrintPreviewDestinationSearchTest', 'Select', function() {
});
test('ReceiveSuccessfulSetup', function() {
-
var destId = "00112233DEADBEEF";
var waiter = waitForEvent(
@@ -216,24 +215,21 @@ TEST_F('PrintPreviewDestinationSearchTest', 'Select', function() {
});
});
- test('ReceiveFailedSetup', function() {
- var destId = '00112233DEADBEEF';
+ if (cr.isChromeOS) {
+ // The 'ResolutionFails' test covers this case for non-CrOS.
+ test('ReceiveFailedSetup', function() {
+ var destId = '00112233DEADBEEF';
- var resolver = mockSetupCall(destId, nativeLayer_);
- requestSetup(destId, destinationSearch_);
+ var resolver = mockSetupCall(destId, nativeLayer_);
+ requestSetup(destId, destinationSearch_);
- // Force resolution to fail.
- resolveSetup(resolver, destId, false, null);
+ // Force resolution to fail.
+ resolveSetup(resolver, destId, false, null);
- if (cr.isChromeOS) {
// Selection should not change on ChromeOS.
assertEquals(null, destinationStore_.selectedDestination);
- } else {
- // Other code expects selection to be present so it still occurs
- // for non-CrOS.
- assertEquals(destId, destinationStore_.selectedDestination.id);
- }
- });
+ });
+ }
});
mocha.run();
« no previous file with comments | « chrome/browser/ui/webui/print_preview/print_preview_handler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698