Implement Dart 1.0 LUB algorithm (for interface types) in kernel.

Implement Dart 1.0 LUB algorithm (for interface types) in kernel.

Note: I intend to implement the full LUB algorithm (including strong
mode behaviors) in front_end, however this piece of the algorithm
makes sense to be in kernel so that it can take advantage of
_ClassInfo.

R=ahe@google.com, johnniwinther@google.com

Committed: https://github.com/dart-lang/sdk/commit/29570728a3fa91f43f9805b30cca8294fe579227

[Paul Berry, 2017-04-28 21:46:09]

paulberry@google.com changed reviewers:
+ ahe@google.com, johnniwinther@google.com, karlklose@chromium.org

[Paul Berry, 2017-05-01 12:35:15]

Friendly ping.  I'd love to be able to land this during my workday today.

[Johnni Winther, 2017-05-01 13:42:27]

Algorithm lgtm with respect to the spec. Await full review from ahe@.

[ahe, 2017-05-01 16:50:34]

lgtm

https://codereview.chromium.org/2848083002/diff/1/pkg/kernel/lib/class_hierar...
File pkg/kernel/lib/class_hierarchy.dart (right):

https://codereview.chromium.org/2848083002/diff/1/pkg/kernel/lib/class_hierar...
pkg/kernel/lib/class_hierarchy.dart:76: List<Class>
getLeastUpperBoundClasses(Class class_) {
Consider renaming to something like getRankedSupertypes.

https://codereview.chromium.org/2848083002/diff/1/pkg/kernel/lib/class_hierar...
pkg/kernel/lib/class_hierarchy.dart:108: /// Given two interfaces I and J, lest
S_I be the set of superinterfaces of I,
lest -> let.

https://codereview.chromium.org/2848083002/diff/1/pkg/kernel/lib/heap.dart
File pkg/kernel/lib/heap.dart (right):

https://codereview.chromium.org/2848083002/diff/1/pkg/kernel/lib/heap.dart#ne...
pkg/kernel/lib/heap.dart:6: abstract class Heap<T> {
Should this be in src or somewhere?

https://codereview.chromium.org/2848083002/diff/1/pkg/kernel/test/heap_test.dart
File pkg/kernel/test/heap_test.dart (right):

https://codereview.chromium.org/2848083002/diff/1/pkg/kernel/test/heap_test.d...
pkg/kernel/test/heap_test.dart:10: var values = <int>[3, 1, 4, 1, 5, 9, 2, 6];
Would it make sense to test a list that is sorted, and one that is reversed
sorted?

https://codereview.chromium.org/2848083002/diff/1/pkg/kernel/test/lub_test.dart
File pkg/kernel/test/lub_test.dart (right):

https://codereview.chromium.org/2848083002/diff/1/pkg/kernel/test/lub_test.da...
pkg/kernel/test/lub_test.dart:13: var library = new
Library(Uri.parse('file:///test.dart'))..parent = program;
Consider using a dummy-URL like this: org-dartlang:///test.dart

[Paul Berry, 2017-05-01 18:12:14]

https://codereview.chromium.org/2848083002/diff/1/pkg/kernel/lib/class_hierar...
File pkg/kernel/lib/class_hierarchy.dart (right):

https://codereview.chromium.org/2848083002/diff/1/pkg/kernel/lib/class_hierar...
pkg/kernel/lib/class_hierarchy.dart:76: List<Class>
getLeastUpperBoundClasses(Class class_) {
On 2017/05/01 16:50:34, ahe wrote:
> Consider renaming to something like getRankedSupertypes.

Done.  I went with "getRankedSuperclasses" to emphasize that this returns a list
of classes, not a list of types.

https://codereview.chromium.org/2848083002/diff/1/pkg/kernel/lib/class_hierar...
pkg/kernel/lib/class_hierarchy.dart:108: /// Given two interfaces I and J, lest
S_I be the set of superinterfaces of I,
On 2017/05/01 16:50:34, ahe wrote:
> lest -> let.

Done.

https://codereview.chromium.org/2848083002/diff/1/pkg/kernel/lib/heap.dart
File pkg/kernel/lib/heap.dart (right):

https://codereview.chromium.org/2848083002/diff/1/pkg/kernel/lib/heap.dart#ne...
pkg/kernel/lib/heap.dart:6: abstract class Heap<T> {
On 2017/05/01 16:50:34, ahe wrote:
> Should this be in src or somewhere?

Good point.  Done.

https://codereview.chromium.org/2848083002/diff/1/pkg/kernel/test/heap_test.dart
File pkg/kernel/test/heap_test.dart (right):

https://codereview.chromium.org/2848083002/diff/1/pkg/kernel/test/heap_test.d...
pkg/kernel/test/heap_test.dart:10: var values = <int>[3, 1, 4, 1, 5, 9, 2, 6];
On 2017/05/01 16:50:34, ahe wrote:
> Would it make sense to test a list that is sorted, and one that is reversed
> sorted?

Yes, good idea.  Done.

https://codereview.chromium.org/2848083002/diff/1/pkg/kernel/test/lub_test.dart
File pkg/kernel/test/lub_test.dart (right):

https://codereview.chromium.org/2848083002/diff/1/pkg/kernel/test/lub_test.da...
pkg/kernel/test/lub_test.dart:13: var library = new
Library(Uri.parse('file:///test.dart'))..parent = program;
On 2017/05/01 16:50:34, ahe wrote:
> Consider using a dummy-URL like this: org-dartlang:///test.dart

Done.

[Paul Berry, 2017-05-01 18:25:51]

Description was changed from

==========
Implement Dart 1.0 LUB algorithm (for interface types) in kernel.

Note: I intend to implement the full LUB algorithm (including strong
mode behaviors) in front_end, however this piece of the algorithm
makes sense to be in kernel so that it can take advantage of
_ClassInfo.
==========

to

==========
Implement Dart 1.0 LUB algorithm (for interface types) in kernel.

Note: I intend to implement the full LUB algorithm (including strong
mode behaviors) in front_end, however this piece of the algorithm
makes sense to be in kernel so that it can take advantage of
_ClassInfo.

R=ahe@google.com, johnniwinther@google.com

Committed:
https://github.com/dart-lang/sdk/commit/29570728a3fa91f43f9805b30cca8294fe579227
==========

[Paul Berry, 2017-05-01 18:25:52]

Committed patchset #1 (id:1) manually as
29570728a3fa91f43f9805b30cca8294fe579227 (presubmit successful).