Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.h

Issue 2848043002: Refactor WebView resize and update-after-layout methods (Closed)
Patch Set: Tweak names Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebViewImpl.h
diff --git a/third_party/WebKit/Source/web/WebViewImpl.h b/third_party/WebKit/Source/web/WebViewImpl.h
index 0dc6355633893842f280583834e3cc0d71402b99..a40f52fee6fe5b6d70214f1fb21836895e0872d9 100644
--- a/third_party/WebKit/Source/web/WebViewImpl.h
+++ b/third_party/WebKit/Source/web/WebViewImpl.h
@@ -347,14 +347,13 @@ class WEB_EXPORT WebViewImpl final
void DidCommitLoad(bool is_new_navigation,
bool is_navigation_within_page) override;
- void PostLayoutResize(WebLocalFrameImpl* webframe);
-
// Indicates two things:
// 1) This view may have a new layout now.
// 2) Calling updateAllLifecyclePhases() is a no-op.
// After calling WebWidget::updateAllLifecyclePhases(), expect to get this
// notification unless the view did not need a layout.
void LayoutUpdated(WebLocalFrameImpl*);
+ void ResizeAfterLayout(WebLocalFrameImpl*);
void DidChangeContentsSize() override;
void PageScaleFactorChanged() override;
@@ -520,7 +519,8 @@ class WEB_EXPORT WebViewImpl final
void RefreshPageScaleFactorAfterLayout();
IntSize ContentsSize() const;
- void PerformResize();
+ void ResizeFrameView(WebLocalFrameImpl* webframe);
+ void UpdateICBAndResizeViewport();
void ResizeViewWhileAnchored(float browser_controls_height,
bool browser_controls_shrink_layout);

Powered by Google App Engine
This is Rietveld 408576698