Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2848033002: Don't include parameter names in types, don't use Unicode arrow. (Closed)

Created:
3 years, 7 months ago by scheglov
Modified:
3 years, 7 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't include parameter names in types, don't use Unicode arrow. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/911ed9ab9429e1fb634f83ff4451305a0e4a8d77

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -139 lines) Patch
M pkg/analyzer/test/src/task/strong/front_end_inference_test.dart View 2 chunks +1 line, -3 lines 0 comments Download
M pkg/front_end/testcases/inference/async_closure_return_type_flatten.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/async_closure_return_type_future.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/front_end/testcases/inference/async_closure_return_type_future_or.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/block_bodied_lambdas_async_all_returns_are_futures.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/block_bodied_lambdas_async_all_returns_are_values.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/block_bodied_lambdas_async_mix_of_values_and_futures.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/block_bodied_lambdas_async_star.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/block_bodied_lambdas_downwards_incompatible_with_upwards_inference.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/block_bodied_lambdas_downwards_incompatible_with_upwards_inference_top_level.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/block_bodied_lambdas_infer_bottom_async.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/block_bodied_lambdas_infer_bottom_async_star.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/block_bodied_lambdas_infer_bottom_sync.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/block_bodied_lambdas_infer_bottom_sync_star.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/block_bodied_lambdas_nested_lambdas.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/block_bodied_lambdas_sync_star.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/bottom_in_closure.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/downwards_inference_on_function_of_t_using_the_t.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/downwards_inference_on_generic_function_expressions.dart View 4 chunks +6 lines, -6 lines 0 comments Download
M pkg/front_end/testcases/inference/downwards_inference_on_list_literals_infer_if_value_types_match_context.dart View 3 chunks +35 lines, -76 lines 0 comments Download
M pkg/front_end/testcases/inference/generic_functions_return_typedef.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/generic_methods_uses_greatest_lower_bound.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/inferred_type_block_closure_no_args_no_return.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/inferred_type_extract_method_tear_off.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/inferred_type_extract_method_tear_off_via_interface.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/inferred_type_from_top_level_executable_tear_off.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/inferred_type_is_typedef.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/inferred_type_is_typedef_parameterized.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/inferred_type_uses_synthetic_function_type.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/inferred_type_uses_synthetic_function_type_function_typed_param.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/inferred_type_uses_synthetic_function_type_named_param.dart View 1 chunk +1 line, -4 lines 0 comments Download
M pkg/front_end/testcases/inference/inferred_type_uses_synthetic_function_type_positional_param.dart View 1 chunk +1 line, -4 lines 0 comments Download
M pkg/front_end/testcases/inference/inferred_type_uses_synthetic_function_type_required_param.dart View 1 chunk +1 line, -4 lines 0 comments Download
M pkg/front_end/testcases/inference/inferred_type_via_closure_multiple_levels_of_nesting.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/inferred_type_via_closure_type_depends_on_args.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/inferred_type_via_closure_type_independent_of_args_field.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/inferred_type_via_closure_type_independent_of_args_top_level.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/null_literal_should_not_infer_as_bottom.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/static_method_tear_off.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_in_list_typed.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_in_list_untyped.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_in_map_typed.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_in_map_untyped.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 7 months ago (2017-04-28 17:53:44 UTC) #1
Paul Berry
lgtm
3 years, 7 months ago (2017-04-28 17:57:51 UTC) #2
scheglov
3 years, 7 months ago (2017-04-28 17:59:57 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
911ed9ab9429e1fb634f83ff4451305a0e4a8d77 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698