Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 284793003: Implement languagechange event, fired when accept languages changes. (Closed)

Created:
6 years, 7 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 6 months ago
CC:
blink-reviews, jamesr, arv+blink, blink-reviews-html_chromium.org, abarth-chromium, dglazkov+blink, Inactive, watchdog-blink-watchlist_google.com
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix tests #

Total comments: 8

Patch Set 3 : review comments #

Patch Set 4 : rebase and add tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -0 lines) Patch
M LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A LayoutTests/navigator_language/navigator_language.html View 1 2 3 1 chunk +91 lines, -0 lines 0 comments Download
M Source/core/events/EventTypeNames.in View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/frame/DOMWindowEventHandlers.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/frame/WindowEventHandlers.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLAttributeNames.in View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLBodyElement.cpp View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/HTMLFrameSetElement.cpp View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/page/Page.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/page/Page.cpp View 1 2 3 1 chunk +11 lines, -0 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 34 (0 generated)
mlamouri (slow - plz ping)
6 years, 7 months ago (2014-05-13 06:45:17 UTC) #1
jochen (gone - plz use gerrit)
https://codereview.chromium.org/284793003/diff/20001/LayoutTests/navigator_language/navigator_language.html File LayoutTests/navigator_language/navigator_language.html (right): https://codereview.chromium.org/284793003/diff/20001/LayoutTests/navigator_language/navigator_language.html#newcode1 LayoutTests/navigator_language/navigator_language.html:1: <!DOCTYPE html> where are the expected results? https://codereview.chromium.org/284793003/diff/20001/LayoutTests/navigator_language/navigator_language.html#newcode9 LayoutTests/navigator_language/navigator_language.html:9: ...
6 years, 7 months ago (2014-05-21 09:20:10 UTC) #2
mlamouri (slow - plz ping)
PTAL https://codereview.chromium.org/284793003/diff/20001/LayoutTests/navigator_language/navigator_language.html File LayoutTests/navigator_language/navigator_language.html (right): https://codereview.chromium.org/284793003/diff/20001/LayoutTests/navigator_language/navigator_language.html#newcode1 LayoutTests/navigator_language/navigator_language.html:1: <!DOCTYPE html> On 2014/05/21 09:20:11, jochen wrote: > ...
6 years, 7 months ago (2014-05-21 16:27:55 UTC) #3
mlamouri (slow - plz ping)
jochen, did you had a chance to have a look at those changes?
6 years, 7 months ago (2014-05-23 09:53:10 UTC) #4
jochen (gone - plz use gerrit)
On 2014/05/23 09:53:10, Mounir Lamouri wrote: > jochen, did you had a chance to have ...
6 years, 7 months ago (2014-05-23 13:25:35 UTC) #5
mlamouri (slow - plz ping)
On 2014/05/23 13:25:35, jochen wrote: > On 2014/05/23 09:53:10, Mounir Lamouri wrote: > > jochen, ...
6 years, 7 months ago (2014-05-23 13:34:01 UTC) #6
mlamouri (slow - plz ping)
On 2014/05/23 13:34:01, Mounir Lamouri wrote: > On 2014/05/23 13:25:35, jochen wrote: > > On ...
6 years, 7 months ago (2014-05-23 13:41:42 UTC) #7
jochen (gone - plz use gerrit)
lgtm
6 years, 7 months ago (2014-05-23 14:05:23 UTC) #8
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 7 months ago (2014-05-25 13:05:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/284793003/60001
6 years, 7 months ago (2014-05-25 13:05:12 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-26 04:37:40 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-26 05:46:21 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/9094)
6 years, 7 months ago (2014-05-26 05:46:21 UTC) #13
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 6 months ago (2014-05-29 11:42:10 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/284793003/60001
6 years, 6 months ago (2014-05-29 11:43:08 UTC) #15
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-05-29 13:03:10 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-29 13:51:37 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/9094)
6 years, 6 months ago (2014-05-29 13:51:38 UTC) #18
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 6 months ago (2014-05-29 14:45:48 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/284793003/60001
6 years, 6 months ago (2014-05-29 14:47:44 UTC) #20
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-05-29 15:38:21 UTC) #21
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-29 16:32:55 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/9094)
6 years, 6 months ago (2014-05-29 16:32:56 UTC) #23
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 6 months ago (2014-05-29 16:33:10 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/284793003/60001
6 years, 6 months ago (2014-05-29 16:35:27 UTC) #25
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-05-29 17:28:34 UTC) #26
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-29 18:20:14 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/9094)
6 years, 6 months ago (2014-05-29 18:20:15 UTC) #28
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 6 months ago (2014-05-30 09:23:46 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/284793003/60001
6 years, 6 months ago (2014-05-30 09:24:55 UTC) #30
mlamouri (slow - plz ping)
The CQ bit was unchecked by mlamouri@chromium.org
6 years, 6 months ago (2014-05-30 09:39:18 UTC) #31
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 6 months ago (2014-05-30 13:47:15 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/284793003/60001
6 years, 6 months ago (2014-05-30 13:47:46 UTC) #33
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 14:33:38 UTC) #34
Message was sent while issue was closed. 
Change committed as 175135

Powered by Google App Engine
This is Rietveld 408576698