Don't pass subpixel offsets through non-translation transforms

third_party/WebKit/Source/core/layout/LayoutBox.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
  *           (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
  * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc.
  *               All rights reserved.
  * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
@@ skipping 1182 matching lines @@
                                                   visual_rect_flags))
       return false;
     return true;
   }
 
   // Otherwise, apply the following:
   // 1. Transform.
   // 2. Container offset.
   // 3. Container scroll offset.
   // 4. Perspective applied by container.
-  // 5. Transform flattening.
-  // 6. Expansion for pixel snapping.
+  // 5. Expansion for pixel snapping.
+  // 6. Transform flattening.

[chrishtr, 2017/05/01 20:22:28]

Not an issue you created, but could you make this change?

s/Transform flattening/Transform+flattening/

[Xianzhu, 2017/05/01 22:03:32]

The steps 1 to 4 are actually generate the transform to be applied in step 6, so
I changed the steps to one step "Generate transform" and sub-steps under the
step.

Also moved step 5 to step 1 because it actually a preparation before applying
transform.

   // 7. Container clip.
 
   // 1. Transform.
   TransformationMatrix transform;
   if (Layer() && Layer()->Transform())
     transform.Multiply(Layer()->CurrentTransform());
 
   // 2. Container offset.
   transform.PostTranslate(container_offset.X().ToFloat(),
                           container_offset.Y().ToFloat());
@@ skipping 15 matching lines @@
 
     TransformationMatrix perspective_matrix;
     perspective_matrix.ApplyPerspective(
         container_object->Style()->Perspective());
     perspective_matrix.ApplyTransformOrigin(perspective_origin.X(),
                                             perspective_origin.Y(), 0);
 
     transform = perspective_matrix * transform;
   }
 
-  // 5. Transform flattening.
-  transform_state.ApplyTransform(transform, accumulation);
-
-  // 6. Expansion for pixel snapping.
-  // Use enclosingBoundingBox because we cannot properly compute pixel
+  // 5. Expansion for pixel snapping.
+  // Use EnclosingBoundingBox because we cannot properly compute pixel

[chrishtr, 2017/04/28 23:26:44]

Why does this have to be first now? Don't see it yet.

[Xianzhu, 2017/05/01 18:13:42]

This is to fix the MapToVisualRectInAncestorSpace() problem described in #4. I
thought you agreed the solution, no?

[chrishtr, 2017/05/01 20:22:28]

Oh I see. Yes I did make this change in 2727093002; fixing it to be back the way
it was in non-preserve3d
makes sense.

   // snapping for painted elements within the transform since we don't know
   // the desired subpixel accumulation at this point, and the transform may
   // include a scale.

[chrishtr, 2017/05/01 20:22:28]

Please add a comment saying that pixel-snapping like this only makes sense
for non-preserve3D, and also that it's applicable only for SPv1
paint invalidation use cases, which have no preserve3D.

[Xianzhu, 2017/05/01 22:03:32]

Done.

   if (!preserve3D) {
     transform_state.Flatten();

[chrishtr, 2017/05/01 20:22:28]

if (!preserve3D && !RuntimeEnabledFeatures::slimmingPaintV2Enabled())

[Xianzhu, 2017/05/01 22:03:32]

Done.

     transform_state.SetQuad(
         FloatQuad(transform_state.LastPlanarQuad().EnclosingBoundingBox()));
   }
 
+  // 6. Transform flattening.
+  transform_state.ApplyTransform(transform, accumulation);
+  if (!preserve3D) {
+    transform_state.Flatten();
+    transform_state.SetQuad(FloatQuad(transform_state.LastPlanarQuad()));
+  }
+
   // 7. Container clip.
   if (container_object->IsBox() && container_object != ancestor &&
       container_object->HasClipRelatedProperty()) {
     return ToLayoutBox(container_object)
         ->ApplyBoxClips(transform_state, accumulation, visual_rect_flags);
   }
 
   return true;
 }
 
@@ skipping 4635 matching lines @@
 void LayoutBox::MutableForPainting::
     SavePreviousContentBoxSizeAndLayoutOverflowRect() {
   auto& rare_data = GetLayoutBox().EnsureRareData();
   rare_data.has_previous_content_box_size_and_layout_overflow_rect_ = true;
   rare_data.previous_content_box_size_ = GetLayoutBox().ContentBoxRect().Size();
   rare_data.previous_layout_overflow_rect_ =
       GetLayoutBox().LayoutOverflowRect();
 }
 
 }  // namespace blink