third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/subpixel-offset-scaled-transform-expected.txt - Issue 2847873002: Don't pass subpixel offsets through non-translation transforms

Side by Side Diff: third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/subpixel-offset-scaled-transform-expected.txt

Issue 2847873002: Don't pass subpixel offsets through non-translation transforms (Closed)

Patch Set: - Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/subpixel-offset-scaled-transform-expected.png ('k') | third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 {

	2 "layers": [

	3 {

	4 "name": "LayoutView #document",

	5 "bounds": [800, 600],

	6 "contentsOpaque": true,

	7 "drawsContent": true,

	8 "paintInvalidations": [

	9 {

	10 "object": "LayoutBlockFlow (relative positioned) DIV class='child scal e'",

	11 "rect": [8, 58, 42, 40],

	12 "reason": "bounds change"

	13 },

	14 {

	15 "object": "LayoutBlockFlow (relative positioned) DIV class='child'",

	16 "rect": [23, 8, 41, 40],
	Xianzhu 2017/04/27 22:53:55 This is disable-spinvalidation. The invalidatio This is disable-spinvalidation. The invalidation rect is incorrect or inconsistent with where we paint the child. The child is painted at (8,8 40x40) and (8.3,8 40x40) before and after repaintTest, respectively. The local offset (0.4, 0) is rounded off when snapping to "pixels" in the child's space during painting. The invalidation rect is from the slow path (MapToVisualRectInAncestorSpace()) in PaintInvalidationState. PaintInvalidator MapToVisualRectInAncestorSpace LocalVisualRect (0,0 1x1) (0,0 1x1) +local offset (0.4,0 1x1) (0.4,0 1x1) EnclosingIntRect (0,0 2x1) Transformed (0,0 80x40) (~15,0 40x40) EnclosingBoundingBox (~15,0 41x40) +container offset (8.3,8 80x40) (~23,8 41x40) The difference comes from the EnclosingIntRect step. Should we call EnclosingIntRect() before applying transform in MapToVisualRectInAncestorSpace? It was changed to EnclosingBoundingRect after transform in https://codereview.chromium.org/2727093002. chrishtr 2017/04/28 02:23:53 I think in general it has to be that way, at least Show quoted text On 2017/04/27 at 22:53:55, Xianzhu wrote: > This is disable-spinvalidation. > > The invalidation rect is incorrect or inconsistent with where we paint the child. The child is painted at (8,8 40x40) and (8.3,8 40x40) before and after repaintTest, respectively. The local offset (0.4, 0) is rounded off when snapping to "pixels" in the child's space during painting. > > The invalidation rect is from the slow path (MapToVisualRectInAncestorSpace()) in PaintInvalidationState. > > PaintInvalidator MapToVisualRectInAncestorSpace > LocalVisualRect (0,0 1x1) (0,0 1x1) > +local offset (0.4,0 1x1) (0.4,0 1x1) > EnclosingIntRect (0,0 2x1) > Transformed (0,0 80x40) (~15,0 40x40) > EnclosingBoundingBox (~15,0 41x40) > +container offset (8.3,8 80x40) (~23,8 41x40) > > The difference comes from the EnclosingIntRect step. Should we call EnclosingIntRect() before applying transform in MapToVisualRectInAncestorSpace? It was changed to EnclosingBoundingRect after transform in https://codereview.chromium.org/2727093002. I think in general it has to be that way, at least for non-spinvalidation, because the paint offset is not known, so invalidations for 2D transforms that are "identity or translation" would incur under-invalidations.
	17 "reason": "location change"

	18 },

	19 {

	20 "object": "LayoutBlockFlow (relative positioned) DIV class='child scal e'",

	21 "rect": [8, 58, 41, 40],

	22 "reason": "bounds change"

	23 }

	24 ],

	25 "underPaintInvalidations": [

	26 {

	27 "x": 8,

	28 "y": 8,

	29 "oldPixel": "#0000FF",

	30 "newPixel": "#4B4BFF"

	31 },

	32 {

	33 "x": 8,

	34 "y": 9,

	35 "oldPixel": "#0000FF",

	36 "newPixel": "#4B4BFF"

	37 },

	38 {

	39 "x": 8,

	40 "y": 10,

	41 "oldPixel": "#0000FF",

	42 "newPixel": "#4B4BFF"

	43 },

	44 {

	45 "x": 8,

	46 "y": 11,

	47 "oldPixel": "#0000FF",

	48 "newPixel": "#4B4BFF"

	49 },

	50 {

	51 "x": 8,

	52 "y": 12,

	53 "oldPixel": "#0000FF",

	54 "newPixel": "#4B4BFF"

	55 },

	56 {

	57 "x": 8,

	58 "y": 13,

	59 "oldPixel": "#0000FF",

	60 "newPixel": "#4B4BFF"

	61 },

	62 {

	63 "x": 8,

	64 "y": 14,

	65 "oldPixel": "#0000FF",

	66 "newPixel": "#4B4BFF"

	67 },

	68 {

	69 "x": 8,

	70 "y": 15,

	71 "oldPixel": "#0000FF",

	72 "newPixel": "#4B4BFF"

	73 },

	74 {

	75 "x": 8,

	76 "y": 16,

	77 "oldPixel": "#0000FF",

	78 "newPixel": "#4B4BFF"

	79 },

	80 {

	81 "x": 8,

	82 "y": 17,

	83 "oldPixel": "#0000FF",

	84 "newPixel": "#4B4BFF"

	85 },

	86 {

	87 "x": 8,

	88 "y": 18,

	89 "oldPixel": "#0000FF",

	90 "newPixel": "#4B4BFF"

	91 },

	92 {

	93 "x": 8,

	94 "y": 19,

	95 "oldPixel": "#0000FF",

	96 "newPixel": "#4B4BFF"

	97 },

	98 {

	99 "x": 8,

	100 "y": 20,

	101 "oldPixel": "#0000FF",

	102 "newPixel": "#4B4BFF"

	103 },

	104 {

	105 "x": 8,

	106 "y": 21,

	107 "oldPixel": "#0000FF",

	108 "newPixel": "#4B4BFF"

	109 },

	110 {

	111 "x": 8,

	112 "y": 22,

	113 "oldPixel": "#0000FF",

	114 "newPixel": "#4B4BFF"

	115 },

	116 {

	117 "x": 8,

	118 "y": 23,

	119 "oldPixel": "#0000FF",

	120 "newPixel": "#4B4BFF"

	121 },

	122 {

	123 "x": 8,

	124 "y": 24,

	125 "oldPixel": "#0000FF",

	126 "newPixel": "#4B4BFF"

	127 },

	128 {

	129 "x": 8,

	130 "y": 25,

	131 "oldPixel": "#0000FF",

	132 "newPixel": "#4B4BFF"

	133 },

	134 {

	135 "x": 8,

	136 "y": 26,

	137 "oldPixel": "#0000FF",

	138 "newPixel": "#4B4BFF"

	139 },

	140 {

	141 "x": 8,

	142 "y": 27,

	143 "oldPixel": "#0000FF",

	144 "newPixel": "#4B4BFF"

	145 },

	146 {

	147 "x": 8,

	148 "y": 28,

	149 "oldPixel": "#0000FF",

	150 "newPixel": "#4B4BFF"

	151 },

	152 {

	153 "x": 8,

	154 "y": 29,

	155 "oldPixel": "#0000FF",

	156 "newPixel": "#4B4BFF"

	157 },

	158 {

	159 "x": 8,

	160 "y": 30,

	161 "oldPixel": "#0000FF",

	162 "newPixel": "#4B4BFF"

	163 },

	164 {

	165 "x": 8,

	166 "y": 31,

	167 "oldPixel": "#0000FF",

	168 "newPixel": "#4B4BFF"

	169 },

	170 {

	171 "x": 8,

	172 "y": 32,

	173 "oldPixel": "#0000FF",

	174 "newPixel": "#4B4BFF"

	175 },

	176 {

	177 "x": 8,

	178 "y": 33,

	179 "oldPixel": "#0000FF",

	180 "newPixel": "#4B4BFF"

	181 },

	182 {

	183 "x": 8,

	184 "y": 34,

	185 "oldPixel": "#0000FF",

	186 "newPixel": "#4B4BFF"

	187 },

	188 {

	189 "x": 8,

	190 "y": 35,

	191 "oldPixel": "#0000FF",

	192 "newPixel": "#4B4BFF"

	193 },

	194 {

	195 "x": 8,

	196 "y": 36,

	197 "oldPixel": "#0000FF",

	198 "newPixel": "#4B4BFF"

	199 },

	200 {

	201 "x": 8,

	202 "y": 37,

	203 "oldPixel": "#0000FF",

	204 "newPixel": "#4B4BFF"

	205 },

	206 {

	207 "x": 8,

	208 "y": 38,

	209 "oldPixel": "#0000FF",

	210 "newPixel": "#4B4BFF"

	211 },

	212 {

	213 "x": 8,

	214 "y": 39,

	215 "oldPixel": "#0000FF",

	216 "newPixel": "#4B4BFF"

	217 },

	218 {

	219 "x": 8,

	220 "y": 40,

	221 "oldPixel": "#0000FF",

	222 "newPixel": "#4B4BFF"

	223 },

	224 {

	225 "x": 8,

	226 "y": 41,

	227 "oldPixel": "#0000FF",

	228 "newPixel": "#4B4BFF"

	229 },

	230 {

	231 "x": 8,

	232 "y": 42,

	233 "oldPixel": "#0000FF",

	234 "newPixel": "#4B4BFF"

	235 },

	236 {

	237 "x": 8,

	238 "y": 43,

	239 "oldPixel": "#0000FF",

	240 "newPixel": "#4B4BFF"

	241 },

	242 {

	243 "x": 8,

	244 "y": 44,

	245 "oldPixel": "#0000FF",

	246 "newPixel": "#4B4BFF"

	247 },

	248 {

	249 "x": 8,

	250 "y": 45,

	251 "oldPixel": "#0000FF",

	252 "newPixel": "#4B4BFF"

	253 },

	254 {

	255 "x": 8,

	256 "y": 46,

	257 "oldPixel": "#0000FF",

	258 "newPixel": "#4B4BFF"

	259 },

	260 {

	261 "x": 8,

	262 "y": 47,

	263 "oldPixel": "#0000FF",

	264 "newPixel": "#4B4BFF"

	265 }

	266 ]

	267 }

	268 ],

	269 "objectPaintInvalidations": [

	270 {

	271 "object": "LayoutBlockFlow (relative positioned) DIV class='child'",

	272 "reason": "location change"

	273 },

	274 {

	275 "object": "LayoutBlockFlow (relative positioned) DIV class='child scale'",

	276 "reason": "bounds change"

	277 }

	278 ]

	279 }

	280

OLD	NEW