Unfork IDS_PAGE_INFO_NON_SECURE_TRANSPORT into IDS_PAGEINFO_NOT_SECURE_SUMMARY

ios/chrome/browser/ui/dialogs/nsurl_protection_space_util.mm

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/ui/dialogs/nsurl_protection_space_util.h"
 
 #include "base/numerics/safe_conversions.h"
 #include "base/strings/sys_string_conversions.h"
 #include "components/strings/grit/components_strings.h"
 #include "components/url_formatter/elide_url.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "url/gurl.h"
 #include "url/scheme_host_port.h"
 
 #if !defined(__has_feature) || !__has_feature(objc_arc)
 #error "This file requires ARC support."
 #endif
 
 namespace ios_internal {
 namespace nsurlprotectionspace_util {
 
 NSString* MessageForHTTPAuth(NSURLProtectionSpace* protectionSpace) {
   DCHECK(CanShow(protectionSpace));
 
   if (protectionSpace.receivesCredentialSecurely)
     return RequesterIdentity(protectionSpace);
 
   NSString* securityWarning =
-      l10n_util::GetNSString(IDS_PAGE_INFO_NON_SECURE_TRANSPORT);
+      l10n_util::GetNSString(IDS_PAGEINFO_NOT_SECURE_SUMMARY);

[estark, 2017/04/28 04:49:31]

It's a little weird that these http auth dialogs use PAGEINFO strings, isn't it?
Do they have anything to do with page info or does the string just happen to be
appropriate?

[meacer, 2017/04/28 15:28:40]

ISTR they were added when we decided we couldn't reliably display SSL info on
the HTTP auth dialog. I wonder why it always says "not secure" though, that
doesn't sound right. It could be for proxy auth dialogs, I'll need to check.

   return
       [NSString stringWithFormat:@"%@ %@", RequesterIdentity(protectionSpace),
                                  securityWarning];
 }
 
 BOOL CanShow(NSURLProtectionSpace* protectionSpace) {
   if (protectionSpace.host.length == 0)
     return NO;
 
   if (!base::IsValueInRangeForNumericType<uint16_t>(protectionSpace.port))
@@ skipping 23 matching lines @@
 GURL RequesterOrigin(NSURLProtectionSpace* protectionSpace) {
   std::string scheme = base::SysNSStringToUTF8(protectionSpace.protocol);
   std::string host = base::SysNSStringToUTF8(protectionSpace.host);
   uint16_t port = base::checked_cast<uint16_t>(protectionSpace.port);
 
   return GURL(url::SchemeHostPort(scheme, host, port).Serialize());
 }
 
 }  // namespace nsurlprotectionspace_util
 }  // namespace ios_internal