Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Unified Diff: remoting/host/it2me/it2me_host.h

Issue 2847853003: Remove policy watching from It2MeHost. (Closed)
Patch Set: Fix unit tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/host/it2me/it2me_host.h
diff --git a/remoting/host/it2me/it2me_host.h b/remoting/host/it2me/it2me_host.h
index 95390c440677daabff29010184231c9df4b4bd63..8b629c1be44caa885ee0a7216cd9f78329475abe 100644
--- a/remoting/host/it2me/it2me_host.h
+++ b/remoting/host/it2me/it2me_host.h
@@ -33,7 +33,6 @@ class ChromotingHostContext;
class DesktopEnvironmentFactory;
class HostEventLogger;
class HostStatusLogger;
-class PolicyWatcher;
class RegisterSupportHostRequest;
class RsaKeyPair;
@@ -65,7 +64,6 @@ class It2MeHost : public base::RefCountedThreadSafe<It2MeHost>,
};
It2MeHost(std::unique_ptr<ChromotingHostContext> context,
- std::unique_ptr<PolicyWatcher> policy_watcher,
std::unique_ptr<It2MeConfirmationDialogFactory> dialog_factory_,
base::WeakPtr<It2MeHost::Observer> observer,
std::unique_ptr<SignalStrategy> signal_strategy,
@@ -99,6 +97,9 @@ class It2MeHost : public base::RefCountedThreadSafe<It2MeHost>,
protocol::ValidatingAuthenticator::ValidationCallback
GetValidationCallbackForTesting();
+ // Called when initial policies are read, and when they change.
+ void OnPolicyUpdate(std::unique_ptr<base::DictionaryValue> policies);
+
protected:
friend class base::RefCountedThreadSafe<It2MeHost>;
@@ -130,12 +131,6 @@ class It2MeHost : public base::RefCountedThreadSafe<It2MeHost>,
const base::TimeDelta& lifetime,
const std::string& error_message);
- // Called when initial policies are read, and when they change.
- void OnPolicyUpdate(std::unique_ptr<base::DictionaryValue> policies);
-
- // Called when malformed policies are detected.
- void OnPolicyError();
-
// Handlers for NAT traversal and domain policies.
void UpdateNatPolicy(bool nat_traversal_enabled);
void UpdateHostDomainListPolicy(std::vector<std::string> host_domain_list);
@@ -168,7 +163,6 @@ class It2MeHost : public base::RefCountedThreadSafe<It2MeHost>,
std::unique_ptr<ChromotingHost> host_;
int failed_login_attempts_ = 0;
- std::unique_ptr<PolicyWatcher> policy_watcher_;
std::unique_ptr<It2MeConfirmationDialogFactory> confirmation_dialog_factory_;
std::unique_ptr<It2MeConfirmationDialogProxy> confirmation_dialog_proxy_;
« no previous file with comments | « no previous file | remoting/host/it2me/it2me_host.cc » ('j') | remoting/host/it2me/it2me_native_messaging_host.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698