base/trace_event/memory_dump_manager.cc - Issue 2847823004: [tracing] Allow enabling heap profiling from chrome://flags

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/memory_dump_manager.cc

Issue 2847823004: [tracing] Allow enabling heap profiling from chrome://flags (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/trace_event/memory_dump_manager.cc

diff --git a/base/trace_event/memory_dump_manager.cc b/base/trace_event/memory_dump_manager.cc

index a41a14091e4eedca55213eafd980f31a76f03b36..2e3f36d225b1a5e3ed402b50dac35b8caa67d9ef 100644

--- a/base/trace_event/memory_dump_manager.cc

+++ b/base/trace_event/memory_dump_manager.cc

@@ -187,7 +187,7 @@ void MemoryDumpManager::EnableHeapProfilingIfNeeded() {

std::string profiling_mode = CommandLine::ForCurrentProcess()

->GetSwitchValueASCII(switches::kEnableHeapProfiling);

- if (profiling_mode == "") {

+ if (profiling_mode == switches::kEnableHeapProfilingModePseudo) {

AllocationContextTracker::SetCaptureMode(

AllocationContextTracker::CaptureMode::PSEUDO_STACK);

#if !defined(OS_NACL)

« no previous file with comments | « base/base_switches.cc ('k') | chrome/browser/about_flags.cc » ('j') | no next file with comments »