[tracing] Allow enabling heap profiling from chrome://flags

base/base_switches.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Defines all the "base" command-line switches.
 
 #ifndef BASE_BASE_SWITCHES_H_
 #define BASE_BASE_SWITCHES_H_
 
 #include "build/build_config.h"
 
 namespace switches {
 
 extern const char kDisableBreakpad[];
 extern const char kDisableLowEndDeviceMode[];
 extern const char kEnableCrashReporter[];
 extern const char kEnableHeapProfiling[];
+extern const char kEnableHeapProfilingModePseudo[];
 extern const char kEnableHeapProfilingModeNative[];
 extern const char kEnableHeapProfilingTaskProfiler[];

[Wez, 2017/04/28 17:17:12]

Is TaskProfiler not a heap-profiling "mode"?  i.e. should it be
kEnableHeapProfilingModeTaskProfiler?

Or, to shorten the mode names, perhaps call these kHeapProfilingModeFoo since
they are the names of the modes, versus the enable flag itself?

[DmitrySkiba, 2017/04/28 19:39:13]

Yeah, I can see your logic here, but I don't want to bloat this CL with
renaming.

[Wez, 2017/04/29 01:15:10]

Understood; perhaps we can rename in a separate CL. :)

 extern const char kEnableLowEndDeviceMode[];
 extern const char kForceFieldTrials[];
 extern const char kFullMemoryCrashReport[];
 extern const char kNoErrorDialogs[];
 extern const char kProfilerTiming[];
 extern const char kProfilerTimingDisabledValue[];
 extern const char kProfilingFile[];
 extern const char kTestChildProcess[];
 extern const char kTestDoNotInitializeIcu[];
 extern const char kTraceToFile[];
 extern const char kTraceToFileName[];
 extern const char kV[];
 extern const char kVModule[];
 extern const char kWaitForDebugger[];
 
 #if defined(OS_WIN)
 extern const char kDisableUsbKeyboardDetect[];
 #endif
 
 #if defined(OS_POSIX)
 extern const char kEnableCrashReporterForTesting[];
 #endif
 
 }  // namespace switches
 
 #endif  // BASE_BASE_SWITCHES_H_