Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1083)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_block_node_test.cc

Issue 2847823002: Make leading OOF objects to be handled by block layout in LayoutNG (Closed)
Patch Set: fix NGBlockNodeForTest Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_block_node.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/ng/ng_block_node_test.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_block_node_test.cc b/third_party/WebKit/Source/core/layout/ng/ng_block_node_test.cc
index d3becbc086b9845c4ec174e69290d1588d4a7e2e..03859c8d0f97914865eee27743a0bd17bc9bd10b 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_block_node_test.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_block_node_test.cc
@@ -77,9 +77,9 @@ TEST_F(NGBlockNodeForTest, ChildFloatBeforeInline) {
NGBlockNode* container =
new NGBlockNode(GetLayoutObjectByElementId("container"));
NGLayoutInputNode* child1 = container->FirstChild();
- EXPECT_TRUE(child1 && child1->IsInline());
+ EXPECT_TRUE(child1 && child1->IsBlock());
NGLayoutInputNode* child2 = child1->NextSibling();
- EXPECT_EQ(child2, nullptr);
+ EXPECT_TRUE(child2 && child2->IsBlock());
}
TEST_F(NGBlockNodeForTest, ChildFloatAfterInline) {
@@ -143,9 +143,9 @@ TEST_F(NGBlockNodeForTest, ChildOofBeforeInline) {
NGBlockNode* container =
new NGBlockNode(GetLayoutObjectByElementId("container"));
NGLayoutInputNode* child1 = container->FirstChild();
- EXPECT_TRUE(child1 && child1->IsInline());
+ EXPECT_TRUE(child1 && child1->IsBlock());
NGLayoutInputNode* child2 = child1->NextSibling();
- EXPECT_EQ(child2, nullptr);
+ EXPECT_TRUE(child2 && child2->IsBlock());
}
TEST_F(NGBlockNodeForTest, ChildOofAfterInline) {
« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_block_node.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698