third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm_test.cc - Issue 2847823002: Make leading OOF objects to be handled by block layout in LayoutNG

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm_test.cc

Issue 2847823002: Make leading OOF objects to be handled by block layout in LayoutNG (Closed)

Patch Set: fix NGBlockNodeForTest Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.cc ('k') | third_party/WebKit/Source/core/layout/ng/ng_block_node.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm_test.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm_test.cc b/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm_test.cc

index 9ff3226351041018c576698f7d055ee6c82f2db6..a5635533d1c64559a5c18a1e4d0d50881d29f27b 100644

--- a/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm_test.cc

+++ b/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm_test.cc

@@ -144,8 +144,10 @@ TEST_F(NGInlineLayoutAlgorithmTest, TextFloatsAroundFloatsBefore) {

ToNGPhysicalBoxFragment(html_fragment->Children()[0].Get());

auto* container_fragment =

ToNGPhysicalBoxFragment(body_fragment->Children()[0].Get());

- auto* line_box_fragments_wrapper =

+ auto* span_box_fragments_wrapper =

ToNGPhysicalBoxFragment(container_fragment->Children()[0].Get());

+ auto* line_box_fragments_wrapper =

+ ToNGPhysicalBoxFragment(span_box_fragments_wrapper->Children()[0].Get());

Vector<NGPhysicalTextFragment*> text_fragments;

for (const auto& child : line_box_fragments_wrapper->Children()) {

auto* line_box = ToNGPhysicalLineBoxFragment(child.Get());