Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3450)

Unified Diff: base/metrics/field_trial.cc

Issue 2847813004: Specify the trial name when crashing due to missing default group name. (Closed)
Patch Set: Fix crash message. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/metrics/field_trial.cc
diff --git a/base/metrics/field_trial.cc b/base/metrics/field_trial.cc
index 6b38d55bbd95f21dd57a5ae2a858277a9e6e9353..dee935fba0144166af81b167041a580737f08c3c 100644
--- a/base/metrics/field_trial.cc
+++ b/base/metrics/field_trial.cc
@@ -414,7 +414,8 @@ FieldTrial::FieldTrial(const std::string& trial_name,
ref_(FieldTrialList::FieldTrialAllocator::kReferenceNull) {
DCHECK_GT(total_probability, 0);
DCHECK(!trial_name_.empty());
- DCHECK(!default_group_name_.empty());
+ DCHECK(!default_group_name_.empty())
+ << "Trial " << trial_name << " is missing a default group name.";
}
FieldTrial::~FieldTrial() {}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698