Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1162)

Unified Diff: chrome/browser/ui/views/payments/payment_sheet_view_controller.cc

Issue 2847813003: [Web Payments] Fix alignment of certain Payment Sheet labels. (Closed)
Patch Set: Apply the same treatment to the shipping option labels Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/payments/payment_request_views_util.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
diff --git a/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc b/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
index f2a8b69a72f8ca5fca749b3864cc4ceee508d645..32a1d226d8dd0ca9d64a628418f7d71896ac6780 100644
--- a/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
+++ b/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
@@ -539,8 +539,10 @@ PaymentSheetViewController::CreatePaymentSheetSummaryRow() {
constexpr int kMaxNumberOfItemsShown = 2;
for (size_t i = 0; i < items.size() && i < kMaxNumberOfItemsShown; ++i) {
item_summaries_layout->StartRow(0, 0);
- item_summaries_layout->AddView(
- new views::Label(base::UTF8ToUTF16(items[i]->label)));
+ std::unique_ptr<views::Label> summary =
+ base::MakeUnique<views::Label>(base::UTF8ToUTF16(items[i]->label));
+ summary->SetHorizontalAlignment(gfx::ALIGN_LEFT);
+ item_summaries_layout->AddView(summary.release());
item_amounts_layout->StartRow(0, 0);
item_amounts_layout->AddView(new views::Label(
@@ -689,9 +691,16 @@ PaymentSheetViewController::CreatePaymentMethodRow() {
1, views::GridLayout::USE_PREF, 0, 0);
layout->StartRow(0, 0);
- layout->AddView(new views::Label(selected_instrument->label()));
+ std::unique_ptr<views::Label> selected_instrument_label =
+ base::MakeUnique<views::Label>(selected_instrument->label());
+ selected_instrument_label->SetHorizontalAlignment(gfx::ALIGN_LEFT);
+ layout->AddView(selected_instrument_label.release());
+
layout->StartRow(0, 0);
- layout->AddView(new views::Label(selected_instrument->sublabel()));
+ std::unique_ptr<views::Label> selected_instrument_sublabel =
+ base::MakeUnique<views::Label>(selected_instrument->sublabel());
+ selected_instrument_sublabel->SetHorizontalAlignment(gfx::ALIGN_LEFT);
+ layout->AddView(selected_instrument_sublabel.release());
std::unique_ptr<views::ImageView> card_icon_view = CreateInstrumentIconView(
selected_instrument->icon_resource_id(), selected_instrument->label());
« no previous file with comments | « chrome/browser/ui/views/payments/payment_request_views_util.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698