Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: chrome/browser/page_load_metrics/metrics_web_contents_observer.cc

Issue 2847803002: Revert of Break page load metrics test dependency on IPC. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
diff --git a/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc b/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
index d0ebb744b1bff85ca72602b211ce730251175737..3e41fa893e06c3249e92a862b19183e438b6c8f6 100644
--- a/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
+++ b/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
@@ -64,6 +64,7 @@
} // namespace
+// static
MetricsWebContentsObserver::MetricsWebContentsObserver(
content::WebContents* web_contents,
std::unique_ptr<PageLoadMetricsEmbedderInterface> embedder_interface)
@@ -74,7 +75,6 @@
RegisterInputEventObserver(web_contents->GetRenderViewHost());
}
-// static
MetricsWebContentsObserver* MetricsWebContentsObserver::CreateForWebContents(
content::WebContents* web_contents,
std::unique_ptr<PageLoadMetricsEmbedderInterface> embedder_interface) {
@@ -92,9 +92,6 @@
MetricsWebContentsObserver::~MetricsWebContentsObserver() {
// TODO(csharrison): Use a more user-initiated signal for CLOSE.
NotifyPageEndAllLoads(END_CLOSE, UserInitiatedInfo::NotUserInitiated());
-
- for (auto& observer : testing_observers_)
- observer.OnGoingAway();
}
void MetricsWebContentsObserver::RegisterInputEventObserver(
@@ -582,9 +579,6 @@
}
committed_load_->UpdateTiming(timing, metadata);
-
- for (auto& observer : testing_observers_)
- observer.OnTimingUpdated(timing, metadata);
}
bool MetricsWebContentsObserver::ShouldTrackNavigation(
@@ -597,32 +591,4 @@
navigation_handle).ShouldTrack();
}
-void MetricsWebContentsObserver::AddTestingObserver(TestingObserver* observer) {
- if (!testing_observers_.HasObserver(observer))
- testing_observers_.AddObserver(observer);
-}
-
-void MetricsWebContentsObserver::RemoveTestingObserver(
- TestingObserver* observer) {
- testing_observers_.RemoveObserver(observer);
-}
-
-MetricsWebContentsObserver::TestingObserver::TestingObserver(
- content::WebContents* web_contents)
- : observer_(page_load_metrics::MetricsWebContentsObserver::FromWebContents(
- web_contents)) {
- observer_->AddTestingObserver(this);
-}
-
-MetricsWebContentsObserver::TestingObserver::~TestingObserver() {
- if (observer_) {
- observer_->RemoveTestingObserver(this);
- observer_ = nullptr;
- }
-}
-
-void MetricsWebContentsObserver::TestingObserver::OnGoingAway() {
- observer_ = nullptr;
-}
-
} // namespace page_load_metrics

Powered by Google App Engine
This is Rietveld 408576698