third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp - Issue 2847763004: Make InsertTextCommand not to apply style for empty selection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp

Issue 2847763004: Make InsertTextCommand not to apply style for empty selection (Closed)

Patch Set: 2017-04-28T14:41:08 Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/BUILD.gn ('k') | third_party/WebKit/Source/core/editing/commands/InsertTextCommandTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp b/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp

index aeeb8480ee596117640bd197264a8bbc83df9d15..e803959aaee2f344fcc794d62bfc02d30ea125f5 100644

--- a/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp

@@ -276,7 +276,7 @@ void InsertTextCommand::DoApply(EditingState* editing_state) {

GetDocument().GetFrame()->GetEditor().TypingStyle()) {

typing_style->PrepareToApplyAt(end_position,

EditingStyle::kPreserveWritingDirection);

- if (!typing_style->IsEmpty()) {

+ if (!typing_style->IsEmpty() && !EndingSelection().IsNone()) {

ApplyStyle(typing_style, editing_state);

if (editing_state->IsAborted())

return;