Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2847753002: Some changes to prepare for endian change for QUIC: 1) Make data reader/write be able to read/write… (Closed)

Created:
3 years, 7 months ago by Fan Yang
Modified:
3 years, 7 months ago
Reviewers:
Zhongyi Shi
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Some changes to prepare for endian change for QUIC: 1) Make data reader/write be able to read/write integers and floating numbers in big endian. 2) Make data reader/write be able to read/write 24/40/48/56-bit integers. 3) Add functions to read/write QuicPacketNumber, QuicStreamId, QuicStreamOffset in QuicFramer. No functional change expected. Not protected. Merge internal change: 153820887 R=zhongyi@chromium.org BUG=

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+594 lines, -159 lines) Patch
M net/quic/core/crypto/crypto_framer.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M net/quic/core/crypto/null_decrypter.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/core/quic_data_reader.h View 3 chunks +16 lines, -12 lines 0 comments Download
M net/quic/core/quic_data_reader.cc View 2 chunks +48 lines, -11 lines 0 comments Download
M net/quic/core/quic_data_writer.h View 4 chunks +16 lines, -4 lines 0 comments Download
M net/quic/core/quic_data_writer.cc View 4 chunks +33 lines, -15 lines 0 comments Download
M net/quic/core/quic_data_writer_test.cc View 6 chunks +365 lines, -20 lines 1 comment Download
M net/quic/core/quic_framer.h View 4 chunks +19 lines, -10 lines 0 comments Download
M net/quic/core/quic_framer.cc View 31 chunks +85 lines, -82 lines 0 comments Download
M net/quic/core/quic_packet_creator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/platform/api/quic_endian.h View 1 chunk +5 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 7 (4 generated)
Fan Yang
3 years, 7 months ago (2017-04-27 13:45:44 UTC) #1
Zhongyi Shi
https://codereview.chromium.org/2847753002/diff/1/net/quic/core/quic_data_writer_test.cc File net/quic/core/quic_data_writer_test.cc (right): https://codereview.chromium.org/2847753002/diff/1/net/quic/core/quic_data_writer_test.cc#newcode189 net/quic/core/quic_data_writer_test.cc:189: uint16_t encoded_ufloat = reinterpret_cast<uint16_t>(test_cases[i].encoded); TestCast::encoded fied by default is ...
3 years, 7 months ago (2017-04-27 18:14:04 UTC) #6
Zhongyi Shi
3 years, 7 months ago (2017-04-27 20:00:08 UTC) #7
lgtm

Powered by Google App Engine
This is Rietveld 408576698