components/password_manager/core/browser/password_reuse_detection_manager.cc - Issue 2847743002: Implementation of sync password reuse checking.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_reuse_detection_manager.cc

Issue 2847743002: Implementation of sync password reuse checking. (Closed)

Patch Set: Addressed comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_reuse_detection_manager.h ('k') | components/password_manager/core/browser/password_reuse_detector.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_reuse_detection_manager.cc

diff --git a/components/password_manager/core/browser/password_reuse_detection_manager.cc b/components/password_manager/core/browser/password_reuse_detection_manager.cc

index ab55375398fa608fb4a02e89179f6ecb10642162..a45670fdc70596ea3a31bb804212699bf6033582 100644

--- a/components/password_manager/core/browser/password_reuse_detection_manager.cc

+++ b/components/password_manager/core/browser/password_reuse_detection_manager.cc

@@ -49,7 +49,7 @@ void PasswordReuseDetectionManager::OnKeyPressed(const base::string16& text) {

void PasswordReuseDetectionManager::OnReuseFound(

const base::string16& password,

- const std::string& saved_domain,

+ const std::string& legitimate_domain,

int saved_passwords,

int number_matches) {

std::unique_ptr<BrowserSavePasswordProgressLogger> logger;

@@ -57,7 +57,7 @@ void PasswordReuseDetectionManager::OnReuseFound(

logger.reset(

new BrowserSavePasswordProgressLogger(client_->GetLogManager()));

logger->LogString(BrowserSavePasswordProgressLogger::STRING_REUSE_FOUND,

- saved_domain);

+ legitimate_domain);

}

metrics_util::LogPasswordReuse(