Skip write barriers when updating the weak hash table.

src/objects.cc

Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index f9a52e59c7455d2986ade2ac70296c2dd5db5034..9d52a49491f17e619f35ab968a1795cdb642f659 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -16168,7 +16168,7 @@ Handle<WeakHashTable> WeakHashTable::Put(Handle<WeakHashTable> table,
   int entry = table->FindEntry(key);
   // Key is already in table, just overwrite value.
   if (entry != kNotFound) {
-    table->set(EntryToValueIndex(entry), *value);
+    table->set(EntryToValueIndex(entry), *value, SKIP_WRITE_BARRIER);

[Michael Starzinger, 2014/05/14 08:38:30]

nit: Can we add a TODO here that skipping the WB is a temporary workaround?

[ulan, 2014/05/14 08:54:04]

Done.

     return table;
   }
 
@@ -16184,8 +16184,8 @@ void WeakHashTable::AddEntry(int entry,
                              Handle<Object> key,
                              Handle<Object> value) {
   DisallowHeapAllocation no_allocation;
-  set(EntryToIndex(entry), *key);
-  set(EntryToValueIndex(entry), *value);
+  set(EntryToIndex(entry), *key, SKIP_WRITE_BARRIER);

[Michael Starzinger, 2014/05/14 08:38:30]

nit: Likewise.

[ulan, 2014/05/14 08:54:04]

Done.

+  set(EntryToValueIndex(entry), *value, SKIP_WRITE_BARRIER);
   ElementAdded();
 }