V8: Roll googletest to 1.8.0.

Roll googletest to 1.8.0.

This is the V8 equivalent to http://crrev.com/2779193002 and must be
landed before //build/secondary/{gtest,gmock} are removed from Chromium.

GoogleTest (gtest) and GoogleMock (gmock) are now hosted into the same
googletest repository. In order to cope with this, the googletest
repository is now sourced at third_party/googletest.

The file/directory layout of Google Test is not yet considered stable.
To minimize disruption while Google Test stabilizes, Chromium code will
be insulated from third_party/googletest.

* testing/gtest/include/gtest/ and testing/gmock/include/gmock have
  been populated with headers that forward into the appropriate
  locations of third_party/googletest

* testing/BUILD.gn has been populated with the targets
  //testing/gtest(:gtest_main) and //testing/gmock(:gmock_main),
  which depend on the appropriate //third_party/googletest targets.

All Chromium code should keep depending on the targets and
headers in testing/{gtest,gmock} for now.

BUG=chromium:630705

[pwnall, 2017-04-27 09:01:23]

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 09:01:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pwnall, 2017-04-27 09:01:55]

Description was changed from

==========
Roll googletest to 1.8.0.

This is the V8 equivalent to http://crrev.com/2779193002

GoogleTest (gtest) and GoogleMock (gmock) are now hosted into the same
googletest repository. In order to cope with this, the googletest
repository is now sourced at third_party/googletest.

The file/directory layout of Google Test is not yet considered stable.
To minimize disruption while Google Test stabilizes, Chromium code will
be insulated from third_party/googletest.

* testing/gtest/include/gtest/ and testing/gmock/include/gmock have
  been populated with headers that forward into the appropriate
  locations of third_party/googletest

* testing/BUILD.gn has been populated with the targets
  //testing/gtest(:gtest_main) and //testing/gmock(:gmock_main),
  which depend on the appropriate //third_party/googletest targets.

All Chromium code should keep depending on the targets and
headers in testing/{gtest,gmock} for now.

BUG=chromium:630705
==========

to

==========
Roll googletest to 1.8.0.

This is the V8 equivalent to http://crrev.com/2779193002

GoogleTest (gtest) and GoogleMock (gmock) are now hosted into the same
googletest repository. In order to cope with this, the googletest
repository is now sourced at third_party/googletest.

The file/directory layout of Google Test is not yet considered stable.
To minimize disruption while Google Test stabilizes, Chromium code will
be insulated from third_party/googletest.

* testing/gtest/include/gtest/ and testing/gmock/include/gmock have
  been populated with headers that forward into the appropriate
  locations of third_party/googletest

* testing/BUILD.gn has been populated with the targets
  //testing/gtest(:gtest_main) and //testing/gmock(:gmock_main),
  which depend on the appropriate //third_party/googletest targets.

All Chromium code should keep depending on the targets and
headers in testing/{gtest,gmock} for now.

BUG=chromium:630705
==========

[commit-bot: I haz the power, 2017-04-27 09:04:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 09:04:29]

Dry run: Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/39921)

[pwnall, 2017-04-27 09:59:20]

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 09:59:30]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 10:05:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 10:05:28]

Dry run: Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/39937)

[pwnall, 2017-04-27 10:20:07]

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

[pwnall, 2017-04-27 10:20:15]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-04-27 10:20:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pwnall, 2017-04-27 10:20:39]

Patchset #1 (id:20001) has been deleted

[commit-bot: I haz the power, 2017-04-27 10:23:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 10:23:28]

Dry run: Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/39939)

[pwnall, 2017-04-27 10:30:30]

Description was changed from

==========
Roll googletest to 1.8.0.

This is the V8 equivalent to http://crrev.com/2779193002

GoogleTest (gtest) and GoogleMock (gmock) are now hosted into the same
googletest repository. In order to cope with this, the googletest
repository is now sourced at third_party/googletest.

The file/directory layout of Google Test is not yet considered stable.
To minimize disruption while Google Test stabilizes, Chromium code will
be insulated from third_party/googletest.

* testing/gtest/include/gtest/ and testing/gmock/include/gmock have
  been populated with headers that forward into the appropriate
  locations of third_party/googletest

* testing/BUILD.gn has been populated with the targets
  //testing/gtest(:gtest_main) and //testing/gmock(:gmock_main),
  which depend on the appropriate //third_party/googletest targets.

All Chromium code should keep depending on the targets and
headers in testing/{gtest,gmock} for now.

BUG=chromium:630705
==========

to

==========
Roll googletest to 1.8.0.

This is the V8 equivalent to http://crrev.com/2779193002 and must be
landed before //build/secondary/{gtest,gmock} are removed from Chromium.

GoogleTest (gtest) and GoogleMock (gmock) are now hosted into the same
googletest repository. In order to cope with this, the googletest
repository is now sourced at third_party/googletest.

The file/directory layout of Google Test is not yet considered stable.
To minimize disruption while Google Test stabilizes, Chromium code will
be insulated from third_party/googletest.

* testing/gtest/include/gtest/ and testing/gmock/include/gmock have
  been populated with headers that forward into the appropriate
  locations of third_party/googletest

* testing/BUILD.gn has been populated with the targets
  //testing/gtest(:gtest_main) and //testing/gmock(:gmock_main),
  which depend on the appropriate //third_party/googletest targets.

All Chromium code should keep depending on the targets and
headers in testing/{gtest,gmock} for now.

BUG=chromium:630705
==========

[pwnall, 2017-04-27 10:32:14]

pwnall@chromium.org changed reviewers:
+ adamk@chromium.org, dpranke@google.com

[pwnall, 2017-04-27 10:32:14]

adamk: Can you please take a look?

dpranke: Can you please check my GYP files? I didn't need to cover GYP for the
Chromium-side CL, and I worry that my GYP is a bit rusty.

[adamk, 2017-04-27 17:18:20]

adamk@chromium.org changed reviewers:
+ machenbach@chromium.org

[adamk, 2017-04-27 17:18:20]

machenbach@ is a better reviewer for build system changes like this one

[pwnall, 2017-04-28 03:28:46]

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 03:28:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 03:30:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 03:30:28]

Dry run: Try jobs failed on following builders:
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/21636)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/40025)

[Michael Achenbach, 2017-04-28 08:19:38]

machenbach@chromium.org changed reviewers:
+ franzih@chromium.org

[Michael Achenbach, 2017-04-28 08:19:39]

Mostly lg. Can't say much about many of the new files, I assume they are similar
to the chromium-side CL?

+ franzih for node.js build. This will also require to adapt the node_update
script and switch it to the new gtest:
https://cs.chromium.org/chromium/src/v8/tools/release/update_node.py?q=update...

Please make the node bot green as well, it's currently running as experimental
trybot, but it's very close to being a blocking bot and breaking it will
probably lead to a revert.

https://codereview.chromium.org/2847693002/diff/60001/testing/gmock/BUILD.gn
File testing/gmock/BUILD.gn (right):

https://codereview.chromium.org/2847693002/diff/60001/testing/gmock/BUILD.gn#...
testing/gmock/BUILD.gn:1: # Copyright 2014 The Chromium Authors. All rights
reserved.
nit: 2017, as it's a new file.

https://codereview.chromium.org/2847693002/diff/60001/testing/gmock/BUILD.gn#...
testing/gmock/BUILD.gn:17: "//third_party/googletest:gmock",
I assume this lands on chromium side first. It also needs to roll into v8.

[Yang, 2017-04-28 08:55:33]

On 2017/04/28 08:19:39, Michael Achenbach wrote:
> Mostly lg. Can't say much about many of the new files, I assume they are
similar
> to the chromium-side CL?
> 
> + franzih for node.js build. This will also require to adapt the node_update
> script and switch it to the new gtest:
>
https://cs.chromium.org/chromium/src/v8/tools/release/update_node.py?q=update...
> 
> Please make the node bot green as well, it's currently running as experimental
> trybot, but it's very close to being a blocking bot and breaking it will
> probably lead to a revert.
> 
> https://codereview.chromium.org/2847693002/diff/60001/testing/gmock/BUILD.gn
> File testing/gmock/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2847693002/diff/60001/testing/gmock/BUILD.gn#...
> testing/gmock/BUILD.gn:1: # Copyright 2014 The Chromium Authors. All rights
> reserved.
> nit: 2017, as it's a new file.
> 
>
https://codereview.chromium.org/2847693002/diff/60001/testing/gmock/BUILD.gn#...
> testing/gmock/BUILD.gn:17: "//third_party/googletest:gmock",
> I assume this lands on chromium side first. It also needs to roll into v8.

What needs to happen to tools/release/update_node.py is this:

- SUB_REPOSITORIES needs to be changed to point to the new DEPS location
third_party/googletest/src
- ADD_TO_GIT_IGNORE needs to be changed so that the rules for
testing/gtest/include/gtest/gtest_prod.h now apply to
third_party/googletest/src/googletest/include/gtest/gtest_prod.h is tracked by
git.
- tools/release/test_update_node.py and tools/release/testdata need to be
adapted to new expectations both wrt .gitignore and paths.
-

[Yang, 2017-04-28 09:04:39]

On 2017/04/28 08:55:33, Yang wrote:
> On 2017/04/28 08:19:39, Michael Achenbach wrote:
> > Mostly lg. Can't say much about many of the new files, I assume they are
> similar
> > to the chromium-side CL?
> > 
> > + franzih for node.js build. This will also require to adapt the node_update
> > script and switch it to the new gtest:
> >
>
https://cs.chromium.org/chromium/src/v8/tools/release/update_node.py?q=update...
> > 
> > Please make the node bot green as well, it's currently running as
experimental
> > trybot, but it's very close to being a blocking bot and breaking it will
> > probably lead to a revert.
> > 
> > https://codereview.chromium.org/2847693002/diff/60001/testing/gmock/BUILD.gn
> > File testing/gmock/BUILD.gn (right):
> > 
> >
>
https://codereview.chromium.org/2847693002/diff/60001/testing/gmock/BUILD.gn#...
> > testing/gmock/BUILD.gn:1: # Copyright 2014 The Chromium Authors. All rights
> > reserved.
> > nit: 2017, as it's a new file.
> > 
> >
>
https://codereview.chromium.org/2847693002/diff/60001/testing/gmock/BUILD.gn#...
> > testing/gmock/BUILD.gn:17: "//third_party/googletest:gmock",
> > I assume this lands on chromium side first. It also needs to roll into v8.
> 
> What needs to happen to tools/release/update_node.py is this:
> 
> - SUB_REPOSITORIES needs to be changed to point to the new DEPS location
> third_party/googletest/src
> - ADD_TO_GIT_IGNORE needs to be changed so that the rules for
> testing/gtest/include/gtest/gtest_prod.h now apply to
> third_party/googletest/src/googletest/include/gtest/gtest_prod.h is tracked by
> git.
> - tools/release/test_update_node.py and tools/release/testdata need to be
> adapted to new expectations both wrt .gitignore and paths.
> -

Turns out this CL does not apply unless you manually delete testing/mock and
testing/gtest first.

[Michael Achenbach, 2017-04-28 09:07:39]

> Turns out this CL does not apply unless you manually delete testing/mock and
> testing/gtest first.

I think the bots clean up automatically. Devs might need to do this manually. No
idea why gclient sync doesn't clean up by default.

[pwnall, 2017-04-28 09:50:59]

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 09:51:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 09:53:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 09:53:53]

Dry run: Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/40065)

[Yang, 2017-04-28 10:58:23]

On 2017/04/28 09:04:39, Yang wrote:
> On 2017/04/28 08:55:33, Yang wrote:
> > On 2017/04/28 08:19:39, Michael Achenbach wrote:
> > > Mostly lg. Can't say much about many of the new files, I assume they are
> > similar
> > > to the chromium-side CL?
> > > 
> > > + franzih for node.js build. This will also require to adapt the
node_update
> > > script and switch it to the new gtest:
> > >
> >
>
https://cs.chromium.org/chromium/src/v8/tools/release/update_node.py?q=update...
> > > 
> > > Please make the node bot green as well, it's currently running as
> experimental
> > > trybot, but it's very close to being a blocking bot and breaking it will
> > > probably lead to a revert.
> > > 
> > >
https://codereview.chromium.org/2847693002/diff/60001/testing/gmock/BUILD.gn
> > > File testing/gmock/BUILD.gn (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/2847693002/diff/60001/testing/gmock/BUILD.gn#...
> > > testing/gmock/BUILD.gn:1: # Copyright 2014 The Chromium Authors. All
rights
> > > reserved.
> > > nit: 2017, as it's a new file.
> > > 
> > >
> >
>
https://codereview.chromium.org/2847693002/diff/60001/testing/gmock/BUILD.gn#...
> > > testing/gmock/BUILD.gn:17: "//third_party/googletest:gmock",
> > > I assume this lands on chromium side first. It also needs to roll into v8.
> > 
> > What needs to happen to tools/release/update_node.py is this:
> > 
> > - SUB_REPOSITORIES needs to be changed to point to the new DEPS location
> > third_party/googletest/src
> > - ADD_TO_GIT_IGNORE needs to be changed so that the rules for
> > testing/gtest/include/gtest/gtest_prod.h now apply to
> > third_party/googletest/src/googletest/include/gtest/gtest_prod.h is tracked
by
> > git.
> > - tools/release/test_update_node.py and tools/release/testdata need to be
> > adapted to new expectations both wrt .gitignore and paths.
> > -
> 
> Turns out this CL does not apply unless you manually delete testing/mock and
> testing/gtest first.


You need something like this to make sure update_node.py keeps working:
https://codereview.chromium.org/2849783003

[pwnall, 2017-05-03 09:54:08]

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 09:54:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pwnall, 2017-05-03 09:55:42]

Patchset #3 (id:80001) has been deleted

[commit-bot: I haz the power, 2017-05-03 09:58:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 09:58:24]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[pwnall, 2017-05-03 10:31:01]

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 10:31:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pwnall, 2017-05-03 10:31:24]

Patchset #3 (id:100001) has been deleted

[commit-bot: I haz the power, 2017-05-03 10:33:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 10:33:51]

Dry run: Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/40342)

[pwnall, 2017-05-03 10:44:24]

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 10:44:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 10:47:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 10:47:23]

Dry run: Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/40344)

[pwnall, 2017-05-03 10:48:00]

On 2017/04/28 10:58:23, Yang wrote:
> On 2017/04/28 09:04:39, Yang wrote:
> > On 2017/04/28 08:55:33, Yang wrote:
> > > On 2017/04/28 08:19:39, Michael Achenbach wrote:
> > > > Mostly lg. Can't say much about many of the new files, I assume they are
> > > similar
> > > > to the chromium-side CL?
> > > > 
> > > > + franzih for node.js build. This will also require to adapt the
> node_update
> > > > script and switch it to the new gtest:
> > > >
> > >
> >
>
https://cs.chromium.org/chromium/src/v8/tools/release/update_node.py?q=update...
> > > > 
> > > > Please make the node bot green as well, it's currently running as
> > experimental
> > > > trybot, but it's very close to being a blocking bot and breaking it will
> > > > probably lead to a revert.
> > > > 
> > > >
> https://codereview.chromium.org/2847693002/diff/60001/testing/gmock/BUILD.gn
> > > > File testing/gmock/BUILD.gn (right):
> > > > 
> > > >
> > >
> >
>
https://codereview.chromium.org/2847693002/diff/60001/testing/gmock/BUILD.gn#...
> > > > testing/gmock/BUILD.gn:1: # Copyright 2014 The Chromium Authors. All
> rights
> > > > reserved.
> > > > nit: 2017, as it's a new file.
> > > > 
> > > >
> > >
> >
>
https://codereview.chromium.org/2847693002/diff/60001/testing/gmock/BUILD.gn#...
> > > > testing/gmock/BUILD.gn:17: "//third_party/googletest:gmock",
> > > > I assume this lands on chromium side first. It also needs to roll into
v8.
> > > 
> > > What needs to happen to tools/release/update_node.py is this:
> > > 
> > > - SUB_REPOSITORIES needs to be changed to point to the new DEPS location
> > > third_party/googletest/src
> > > - ADD_TO_GIT_IGNORE needs to be changed so that the rules for
> > > testing/gtest/include/gtest/gtest_prod.h now apply to
> > > third_party/googletest/src/googletest/include/gtest/gtest_prod.h is
tracked
> by
> > > git.
> > > - tools/release/test_update_node.py and tools/release/testdata need to be
> > > adapted to new expectations both wrt .gitignore and paths.
> > > -
> > 
> > Turns out this CL does not apply unless you manually delete testing/mock and
> > testing/gtest first.
> 
> 
> You need something like this to make sure update_node.py keeps working:
> https://codereview.chromium.org/2849783003

yangguo@: Oh, wow, thank you very much for doing all the work!

Sorry for being slow, I had to attend to another CL. I incorporated your CL and
updated everything, does this look reasonable?

machenbach@: Do you happen to know what I need to do to make the presubmit check
happy? I think I've updated the relevant GN / GYP files :/

Thank you!

[Michael Achenbach, 2017-05-03 12:57:12]

I wasn't able to apply the patch locally. Maybe needs a rebase? I tried on
current ToT:
git cl patch --rietveld 2847693002

I'd check how to fix presubmit. In general it should be just running this tool:
tools/verify_source_deps.py

And then change the whitelist/blacklist/paths in the tool to make it shut up...

https://codereview.chromium.org/2847693002/diff/140001/testing/gtest/include/...
File testing/gtest/include/gtest/gtest_prod.h (right):

https://codereview.chromium.org/2847693002/diff/140001/testing/gtest/include/...
testing/gtest/include/gtest/gtest_prod.h:10: #include
"third_party/googletest/src/googletest/include/gtest/gtest_prod.h"
Where is this file? Not seeing it here:
https://chromium.googlesource.com/external/github.com/google/googletest/+/mas...

This is currently making the gcmole fail.