Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: chromecast/public/media/audio_post_processor_shlib.h

Issue 2847673002: [Chromecast] Complete PostProcessingPipeline changes (Closed)
Patch Set: Fix deps Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/media/cma/backend/alsa/stream_mixer_alsa_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/public/media/audio_post_processor_shlib.h
diff --git a/chromecast/public/media/audio_post_processor_shlib.h b/chromecast/public/media/audio_post_processor_shlib.h
index e8e912a2cda519ffbb4e88b4fd27922879e5f099..1a8434731be189ab787ff39bbd41c5cfc4e41646 100644
--- a/chromecast/public/media/audio_post_processor_shlib.h
+++ b/chromecast/public/media/audio_post_processor_shlib.h
@@ -45,10 +45,8 @@ class AudioPostProcessor {
// always non-zero and less than or equal to 20ms of audio.
// AudioPostProcessor must always provide |frames| frames of data back
// (may output 0’s)
- // |volume| is the attenuation level (multiplier) of the stream.
- // |volume| is between 0 and 1 inclusive.
+ // |volume| is the Cast Volume applied to the stream (normalized to 0-1)
// AudioPostProcessor should assume that it has already been applied.
- // TODO(bshaya): Change |volume| to Cast System Volume.
// Returns the current rendering delay of the filter in frames,
// or negative if an error occurred during processing.
// If an error occurred during processing, |data| should be unchanged.
« no previous file with comments | « chromecast/media/cma/backend/alsa/stream_mixer_alsa_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698