Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(872)

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2847663002: Don't show touch handles when selection hidden (Closed)
Patch Set: added old test back Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/FrameView.cpp
diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp
index 8494a860f4d09910b458768c54de89b22fd622f5..e5674e4298aa6d2850f8313e8671d4cb233cf5d2 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.cpp
+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp
@@ -2069,7 +2069,7 @@ bool FrameView::ComputeCompositedSelection(LocalFrame& frame,
const VisibleSelection& visible_selection =
frame.Selection().ComputeVisibleSelectionInDOMTree();
- if (visible_selection.IsNone() || !frame.Selection().IsHandleVisible())
+ if (!frame.Selection().IsHandleVisible() || frame.Selection().IsHidden())
return false;
// Non-editable caret selections lack any kind of UI affordance, and
« no previous file with comments | « content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698