third_party/WebKit/Source/core/frame/FrameView.cpp - Issue 2847663002: Don't show touch handles when selection hidden

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2847663002: Don't show touch handles when selection hidden (Closed)

Patch Set: Incorporated hugoh's CL Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/FrameView.cpp

diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp

index 8494a860f4d09910b458768c54de89b22fd622f5..e5674e4298aa6d2850f8313e8671d4cb233cf5d2 100644

--- a/third_party/WebKit/Source/core/frame/FrameView.cpp

+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp

@@ -2069,7 +2069,7 @@ bool FrameView::ComputeCompositedSelection(LocalFrame& frame,

const VisibleSelection& visible_selection =

frame.Selection().ComputeVisibleSelectionInDOMTree();

- if (visible_selection.IsNone() || !frame.Selection().IsHandleVisible())

+ if (!frame.Selection().IsHandleVisible() || frame.Selection().IsHidden())

yosin_UTC9 2017/05/16 01:13:09 Thanks for changing order. |FS::IsHidden()| is not

return false;

// Non-editable caret selections lack any kind of UI affordance, and

« no previous file with comments | « content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java ('k') | no next file » | no next file with comments »