Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2733)

Unified Diff: chrome/browser/resources/settings/settings_shared_css.html

Issue 2847583002: [MD settings] css for row separator (Closed)
Patch Set: review changes Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/settings_shared_css.html
diff --git a/chrome/browser/resources/settings/settings_shared_css.html b/chrome/browser/resources/settings/settings_shared_css.html
index 1b42c6494755ecdbc3e90b3d2cafa56223a2cec1..b4f18e76b4ff42f662bc637abf2c24f1d0cc65b2 100644
--- a/chrome/browser/resources/settings/settings_shared_css.html
+++ b/chrome/browser/resources/settings/settings_shared_css.html
@@ -317,8 +317,8 @@
outline: none;
}
- /* The secondary-action wraps a clickable sub-area of a .settings-box.
- * An example is the |sign out| button on the People settings.
+ /* TODO(dschuyler): replace with .separator.
+ * The secondary-action wraps a clickable sub-area of a .settings-box.
* Here is an example with and without a secondary action box:
*
* +-------------------------------------------------------+
@@ -345,6 +345,24 @@
border-top: var(--settings-separator-line);
}
+ /* The separator a vertical line like a horizontal rule <hr> tag, but goes
+ * the other way. An example is near the |sign out| button on the People
+ * settings. */
+ :-webkit-any(.settings-box, .list-item) .separator {
+ -webkit-border-start: var(--settings-separator-line);
+ -webkit-margin-end: var(--settings-box-row-padding);
+ -webkit-margin-start: var(--settings-box-row-padding);
+ flex-shrink: 0;
+ --settings-separator-gaps: 9px;
+ height: calc(var(--settings-row-min-height) -
+ var(--settings-separator-gaps));
+ }
+
+ :-webkit-any(.settings-box, .list-item).two-line .separator {
+ height: calc(var(--settings-row-two-line-min-height) -
+ 2 * var(--settings-separator-gaps));
+ }
+
.settings-checkbox-spacer {
-webkit-margin-start: calc(
var(--checkbox-margin-start) +

Powered by Google App Engine
This is Rietveld 408576698