Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Unified Diff: infra/scripts/legacy/scripts/slave/chromium/sizes.py

Issue 2847533005: Remove references to debian wheezy sysroot (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: infra/scripts/legacy/scripts/slave/chromium/sizes.py
diff --git a/infra/scripts/legacy/scripts/slave/chromium/sizes.py b/infra/scripts/legacy/scripts/slave/chromium/sizes.py
index df09b7cac32c76fe509b340f7479286fa93e1c52..9ffeedf6c0f71a5dfb3f0a1369c115be68a6cc8f 100755
--- a/infra/scripts/legacy/scripts/slave/chromium/sizes.py
+++ b/infra/scripts/legacy/scripts/slave/chromium/sizes.py
@@ -298,15 +298,9 @@ def check_linux_binary(target_dir, binary_name, options):
has_init_array, init_array_size = get_elf_section_size(stdout, 'init_array')
if has_init_array:
si_count = init_array_size / word_size
- si_count = max(si_count, 0)
-
- # In newer versions of gcc crtbegin.o inserts frame_dummy into .init_array
- # but we don't want to count this entry, since it alwasy present and nothing
- # to do with our code.
- # TODO(sbc): Do this unconditionally once we drop support for wheezy (gcc-4.6
- # version of crtbegin.o)
- result, stdout = run_process(result, ['nm', binary_file])
- if '__frame_dummy_init_array_entry' in stdout:
+ # In newer versions of gcc crtbegin.o inserts frame_dummy into .init_array
+ # but we don't want to count this entry, since its alwasys present and not
+ # related to our code.
assert(si_count > 0)
si_count -= 1

Powered by Google App Engine
This is Rietveld 408576698