chrome/browser/ui/views/payments/order_summary_view_controller_browsertest.cc - Issue 2847503002: [WebPayments] Show labels on incomplete profiles

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/payments/order_summary_view_controller_browsertest.cc

Issue 2847503002: [WebPayments] Show labels on incomplete profiles (Closed)

Patch Set: ios namespace Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/ui/views/payments/payment_request_browsertest_base.h » ('j') | chrome/browser/ui/views/payments/payment_request_dialog_view_ids.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/payments/order_summary_view_controller_browsertest.cc

diff --git a/chrome/browser/ui/views/payments/order_summary_view_controller_browsertest.cc b/chrome/browser/ui/views/payments/order_summary_view_controller_browsertest.cc

index b33d48a6627c9ada7b2df2e906025b36d01675bf..c8e607013aa202c5bd133d199436c146d1620349 100644

--- a/chrome/browser/ui/views/payments/order_summary_view_controller_browsertest.cc

+++ b/chrome/browser/ui/views/payments/order_summary_view_controller_browsertest.cc

@@ -59,7 +59,7 @@ IN_PROC_BROWSER_TEST_F(PaymentRequestOrderSummaryViewControllerTest,

DialogViewID::SHIPPING_ADDRESS_SHEET_LIST_VIEW);

// Michigan address is selected and has standard shipping.

- std::vector<base::string16> shipping_address_labels = GetThreeLineLabelValues(

+ std::vector<base::string16> shipping_address_labels = GetProfileLabelValues(

DialogViewID::PAYMENT_SHEET_SHIPPING_ADDRESS_SECTION);

EXPECT_EQ(base::ASCIIToUTF16("Jane A. Smith"), shipping_address_labels[0]);

EXPECT_EQ(

@@ -95,7 +95,7 @@ IN_PROC_BROWSER_TEST_F(PaymentRequestOrderSummaryViewControllerTest,

DialogViewID::SHIPPING_ADDRESS_SHEET_LIST_VIEW);

// California address is selected and has free shipping.

- shipping_address_labels = GetThreeLineLabelValues(

+ shipping_address_labels = GetProfileLabelValues(

DialogViewID::PAYMENT_SHEET_SHIPPING_ADDRESS_SECTION);

EXPECT_EQ(base::ASCIIToUTF16("John H. Doe"), shipping_address_labels[0]);

EXPECT_EQ(base::ASCIIToUTF16(