Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3468)

Unified Diff: chrome/browser/ui/views/payments/payment_request_browsertest_base.cc

Issue 2847503002: [WebPayments] Show labels on incomplete profiles (Closed)
Patch Set: test fix Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/payments/payment_request_browsertest_base.cc
diff --git a/chrome/browser/ui/views/payments/payment_request_browsertest_base.cc b/chrome/browser/ui/views/payments/payment_request_browsertest_base.cc
index 513e143bffbf080da551cf8a8ae1438d2232845e..4f0383b58f4779e5bf5c4dbef209ec34fe7c17cc 100644
--- a/chrome/browser/ui/views/payments/payment_request_browsertest_base.cc
+++ b/chrome/browser/ui/views/payments/payment_request_browsertest_base.cc
@@ -428,7 +428,7 @@ void PaymentRequestBrowserTestBase::ClickOnChildInListViewAndWait(
}
std::vector<base::string16>
-PaymentRequestBrowserTestBase::GetThreeLineLabelValues(
+PaymentRequestBrowserTestBase::GetProfileLabelValues(
DialogViewID parent_view_id) {
std::vector<base::string16> line_labels;
views::View* parent_view =
@@ -436,15 +436,19 @@ PaymentRequestBrowserTestBase::GetThreeLineLabelValues(
EXPECT_TRUE(parent_view);
views::View* view = parent_view->GetViewByID(
- static_cast<int>(DialogViewID::THREE_LINE_LABEL_LINE_1));
+ static_cast<int>(DialogViewID::PROFILE_LABEL_LINE_1));
if (view)
line_labels.push_back(static_cast<views::Label*>(view)->text());
view = parent_view->GetViewByID(
- static_cast<int>(DialogViewID::THREE_LINE_LABEL_LINE_2));
+ static_cast<int>(DialogViewID::PROFILE_LABEL_LINE_2));
if (view)
line_labels.push_back(static_cast<views::Label*>(view)->text());
view = parent_view->GetViewByID(
- static_cast<int>(DialogViewID::THREE_LINE_LABEL_LINE_3));
+ static_cast<int>(DialogViewID::PROFILE_LABEL_LINE_3));
+ if (view)
+ line_labels.push_back(static_cast<views::Label*>(view)->text());
+ view = parent_view->GetViewByID(
+ static_cast<int>(DialogViewID::PROFILE_LABEL_ERROR));
if (view)
line_labels.push_back(static_cast<views::Label*>(view)->text());

Powered by Google App Engine
This is Rietveld 408576698