[WebPayments] Show labels on incomplete profiles

ios/chrome/browser/payments/payment_request.mm

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ios/chrome/browser/payments/payment_request.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "components/autofill/core/browser/autofill_data_util.h"
 #include "components/autofill/core/browser/autofill_profile.h"
 #include "components/autofill/core/browser/credit_card.h"
@@ skipping 80 matching lines @@
 void PaymentRequest::PopulateProfileCache() {
   const std::vector<autofill::AutofillProfile*>& profiles_to_suggest =
       personal_data_manager_->GetProfilesToSuggest();
   profile_cache_.reserve(profiles_to_suggest.size());
   for (const auto* profile : profiles_to_suggest) {
     profile_cache_.push_back(*profile);
     shipping_profiles_.push_back(&profile_cache_.back());
     contact_profiles_.push_back(&profile_cache_.back());
   }
 
+  payments::PaymentsProfileComparator comparator(
+      GetApplicationContext()->GetApplicationLocale(), *this);
+
   // TODO(crbug.com/602666): Implement deduplication and prioritization rules

[Mathieu, 2017/04/27 18:34:01]

is this resolved then?

[tmartino, 2017/04/28 17:10:06]

Nope. We'll want to write a shipping method that's analogous to
FilterProfilesForContact. It would move complete profiles to the top (but
otherwise preserve frecency order) and would do any filtering/merging we need
(though I don't think there's anything we have planned like that for shipping).

   // for shipping profiles.
 
-  contact_profiles_ = payments::profile_util::FilterProfilesForContact(
-      contact_profiles_, GetApplicationContext()->GetApplicationLocale(),
-      *this);
+  contact_profiles_ = comparator.FilterProfilesForContact(contact_profiles_);
 
   if (!shipping_profiles_.empty())
     selected_shipping_profile_ = shipping_profiles_[0];
-  if (!contact_profiles_.empty())
+  if (!contact_profiles_.empty() &&
+      comparator.IsContactInfoComplete(contact_profiles_[0])) {
     selected_contact_profile_ = contact_profiles_[0];
+  }
 }
 
 void PaymentRequest::PopulateCreditCardCache() {
   // TODO(crbug.com/709036): Validate method data.
   payments::data_util::ParseBasicCardSupportedNetworks(
       web_payment_request_.method_data, &supported_card_networks_,
       &basic_card_specified_networks_);
 
   const std::vector<autofill::CreditCard*>& credit_cards_to_suggest =
       personal_data_manager_->GetCreditCardsToSuggest();
@@ skipping 28 matching lines @@
 
   selected_shipping_option_ = nullptr;
   for (auto* shipping_option : shipping_options_) {
     if (shipping_option->selected) {
       // If more than one option has |selected| set, the last one in the
       // sequence should be treated as the selected item.
       selected_shipping_option_ = shipping_option;
     }
   }
 }