[WebPayments] Show labels on incomplete profiles

components/autofill/core/browser/autofill_profile_comparator.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_PROFILE_COMPARATOR_H_
 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_PROFILE_COMPARATOR_H_
 
 #include <memory>
 #include <set>
 
@@ skipping 197 matching lines @@
   bool HaveMergeableAddresses(const AutofillProfile& p1,
                               const AutofillProfile& p2) const;
 
   // Populates |name_info| with the result of merging the Chinese, Japanese or
   // Korean names in |p1| and |p2|. Returns true if successful. Expects that
   // |p1| and |p2| have already been found to be mergeable, and have CJK names.
   bool MergeCJKNames(const AutofillProfile& p1,
                      const AutofillProfile& p2,
                      NameInfo* info) const;
 
+  const std::string app_locale_;

[Mathieu, 2017/04/27 18:34:01]

hmm, I think the style is to have a getter() that's visible and app_locale_
stays private

[Mathieu, 2017/04/27 18:34:30]

Also do you need it, can you get it another way?

[tmartino, 2017/04/28 17:10:06]

We take it in at construct-time and pass it to the AutofillProfileComparator. I
guess the alternative would be to store a copy at the subclass level, but that
seems silly. Added a getter.

+
  private:
   l10n::CaseInsensitiveCompare case_insensitive_compare_;
   std::unique_ptr<icu::Transliterator> transliterator_;
-  const std::string app_locale_;
 
   DISALLOW_COPY_AND_ASSIGN(AutofillProfileComparator);
 };
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_PROFILE_COMPARATOR_H_