Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 284743005: [Telemetry] Reduce page cycler cycle time by about another 10% on android. (Closed)

Created:
6 years, 7 months ago by tonyg
Modified:
6 years, 7 months ago
Reviewers:
bulach
CC:
chromium-reviews, telemetry+watch_chromium.org
Visibility:
Public.

Description

[Telemetry] Reduce page cycler cycle time by about another 10% on android. On my device, dumpsys meminfo takes about 900ms. cat /proc/meminfo gives us the same data we need in about 40ms. This also has the nice benefit of sharing the same implemenation as the other proc-supporting backends. This reduces one iteration of moz from 4.5m -> <4m. BUG=372489 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270109

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M tools/telemetry/telemetry/core/platform/android_platform_backend.py View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tonyg
6 years, 7 months ago (2014-05-13 14:00:16 UTC) #1
bulach
lgtm, thanks!
6 years, 7 months ago (2014-05-13 14:11:28 UTC) #2
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 7 months ago (2014-05-13 14:13:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/284743005/1
6 years, 7 months ago (2014-05-13 14:13:38 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-13 15:59:41 UTC) #5
Message was sent while issue was closed.
Change committed as 270109

Powered by Google App Engine
This is Rietveld 408576698