Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(961)

Unified Diff: chrome/browser/apps/ephemeral_app_browsertest.cc

Issue 284743004: Fix time outs in ephemeral apps tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review comments Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/apps/ephemeral_app_browsertest.cc
diff --git a/chrome/browser/apps/ephemeral_app_browsertest.cc b/chrome/browser/apps/ephemeral_app_browsertest.cc
index 1f895c62f8a21315a86920f64250c82031776b63..760cb12b0139412d3597692e17df52b86b31581c 100644
--- a/chrome/browser/apps/ephemeral_app_browsertest.cc
+++ b/chrome/browser/apps/ephemeral_app_browsertest.cc
@@ -128,16 +128,14 @@ class EphemeralAppBrowserTest : public PlatformAppBrowserTest {
return false;
}
+ ResultCatcher catcher;
launched_listener.Reply(test_name);
- ResultCatcher catcher;
- if (!catcher.GetNextResult()) {
- message_ = catcher.message();
- return false;
- }
+ bool result = catcher.GetNextResult();
+ message_ = catcher.message();
CloseApp(app->id());
- return true;
+ return result;
}
void CloseApp(const std::string& app_id) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698