Fix time outs in ephemeral apps tests

chrome/browser/apps/ephemeral_app_browsertest.cc

Index: chrome/browser/apps/ephemeral_app_browsertest.cc
diff --git a/chrome/browser/apps/ephemeral_app_browsertest.cc b/chrome/browser/apps/ephemeral_app_browsertest.cc
index 1f895c62f8a21315a86920f64250c82031776b63..6f5e6e2d134441ea26121c44179bdaea4001f2aa 100644
--- a/chrome/browser/apps/ephemeral_app_browsertest.cc
+++ b/chrome/browser/apps/ephemeral_app_browsertest.cc
@@ -128,16 +128,15 @@ class EphemeralAppBrowserTest : public PlatformAppBrowserTest {
       return false;
     }
 
+    ResultCatcher catcher;
     launched_listener.Reply(test_name);
 
-    ResultCatcher catcher;
-    if (!catcher.GetNextResult()) {
+    bool result = catcher.GetNextResult();
+    if (!result)

[tapted, 2014/05/14 01:54:58]

nit: this `if` probably isn't needed (i.e. do `message_ = catcher.message();`
unconditionally).

ExtensionApiTest::ResultCatcher::Observe(..) seems designed to support message()
returning an empty string on success. (theoretical benefit of this: you could
call LaunchAppAndRunTest multiple times and message_ would be correctly cleared
on success).

       message_ = catcher.message();
-      return false;
-    }
 
     CloseApp(app->id());
-    return true;
+    return result;
   }
 
   void CloseApp(const std::string& app_id) {