Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 2847363002: Create unit tests of ScriptLoader

Created:
3 years, 7 months ago by hiroshige
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Create unit tests of ScriptLoader BUG=694702

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -1 line) Patch
M third_party/WebKit/Source/core/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/MockScriptElementBase.h View 1 chunk +2 lines, -1 line 0 comments Download
A third_party/WebKit/Source/core/dom/ScriptLoaderTest.cpp View 1 chunk +89 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (5 generated)
hiroshige
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-04-29 01:33:35 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847363002/1
3 years, 7 months ago (2017-04-29 01:34:09 UTC) #2
hiroshige
Description was changed from ========== Create unit tests of ScriptLoader BUG= ========== to ========== Create ...
3 years, 7 months ago (2017-04-29 03:04:12 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-04-29 03:27:18 UTC) #4
commit-bot: I haz the power
3 years, 7 months ago (2017-04-29 03:27:19 UTC) #5
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698