Issue 284733005: Revert of Make CompositorImpl::CompositeAndReadback fail and return false.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 284733005: Revert of Make CompositorImpl::CompositeAndReadback fail and return false. (Closed)

Created:
6 years, 7 months ago by danakj

Modified:
6 years, 7 months ago

Reviewers:
powei, piman

CC:
chromium-reviews, darin-cc_chromium.org, jam, brianderson, enne (OOO), piman, aelias_OOO_until_Jul13

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Revert of Make CompositorImpl::CompositeAndReadback fail and return false. (https://codereview.chromium.org/273113004/) Reason for revert: Seems like this broke android pixel tests also: https://code.google.com/p/chromium/issues/detail?id=372562 Original issue's description: > Make CompositorImpl::CompositeAndReadback fail and return false. > > Removes the call to LayerTreeHost::CompositeAndReadback and just fail > immediately. This method should be replaced with an async readback > in order to get pixels again. > > R=powei > BUG=252046 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269931 TBR=powei@chromium.org,piman@chromium.org NOTREECHECKS=true NOTRY=true BUG=252046 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270185