bspatch: Report errors on MBS_ApplyPatch.

third_party/bspatch/mbspatch.cc

Index: third_party/bspatch/mbspatch.cc
diff --git a/third_party/bspatch/mbspatch.cc b/third_party/bspatch/mbspatch.cc
index 164cc3caed0d7bda5c79e629cd4a3404818af178..d00bc99d1297b4cc9bd032f2831f4267b44c7064 100644
--- a/third_party/bspatch/mbspatch.cc
+++ b/third_party/bspatch/mbspatch.cc
@@ -86,7 +86,7 @@ MBS_ReadHeader(int fd, MBSPatchHeader *header)
 
   return OK;
 }
-         
+
 int
 MBS_ApplyPatch(const MBSPatchHeader *header, int patchfd,
                unsigned char *fbuffer, int filefd)
@@ -263,7 +263,7 @@ int ApplyBinaryPatch(const wchar_t *old_file, const wchar_t *patch_file,
       break;
     }
 
-    MBS_ApplyPatch(&header, pfd, buf, nfd);
+    ret = MBS_ApplyPatch(&header, pfd, buf, nfd);

[grt (UTC plus 2), 2014/05/13 15:10:06]

nice catch. shouldn't this be:
    if ((ret = MBS_ApplyPatch(&header, pfd, buf, nfd)))
      break;

[deymo, 2014/05/13 18:14:40]

Yeah, both options work (because this is the last instruction on the 'do {}
while(0)' ). I can change that anyway.

[grt (UTC plus 2), 2014/05/13 18:37:04]

oh, ha. i didn't notice that it was while(0). in that case, lgtm.

   } while (0);
 
   free(buf);