Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1944)

Unified Diff: ash/test/ash_test_base.h

Issue 2847283002: chromeos: convert remaining AshTest usage to AshTestBase (Closed)
Patch Set: comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/test/ash_test.cc ('k') | ash/test/ash_test_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/test/ash_test_base.h
diff --git a/ash/test/ash_test_base.h b/ash/test/ash_test_base.h
index afbc64c684f7ef3f98eb0dacf516a2735a75187a..ddcb800b525c174952e9d3c7e90bfc258ba07e07 100644
--- a/ash/test/ash_test_base.h
+++ b/ash/test/ash_test_base.h
@@ -49,7 +49,6 @@ class WidgetDelegate;
}
namespace ash {
-class AshTestImplAura;
class SystemTray;
class WmShelf;
@@ -103,6 +102,13 @@ class AshTestBase : public testing::Test {
ui::wm::WindowType type = ui::wm::WINDOW_TYPE_NORMAL,
int shell_window_id = kShellWindowId_Invalid);
+ // Creates a visible top-level window. For Config::CLASSIC and Config::MUS
+ // this creates a Window with a delegate. For Config::MASH this creates a
+ // window as if the client requested a top-level window.
+ std::unique_ptr<aura::Window> CreateToplevelTestWindow(
+ const gfx::Rect& bounds_in_screen = gfx::Rect(),
+ int shell_window_id = kShellWindowId_Invalid);
+
// Versions of the functions in aura::test:: that go through our shell
// StackingController instead of taking a parent.
aura::Window* CreateTestWindowInShellWithId(int id);
@@ -193,8 +199,6 @@ class AshTestBase : public testing::Test {
display::Display GetSecondaryDisplay();
private:
- friend class ash::AshTestImplAura;
-
bool setup_called_;
bool teardown_called_;
// |SetUp()| doesn't activate session if this is set to false.
« no previous file with comments | « ash/test/ash_test.cc ('k') | ash/test/ash_test_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698