Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Unified Diff: tools/binary_size/README.md

Issue 2847243005: diagnose_apk_bloat.py: fix error messages and simplify rev order. (Closed)
Patch Set: + README Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/binary_size/diagnose_apk_bloat.py » ('j') | tools/binary_size/diagnose_apk_bloat.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/binary_size/README.md
diff --git a/tools/binary_size/README.md b/tools/binary_size/README.md
index 598e53d206765c1b9dbff3ad10206676f2046edb..b3697015946f483c11518eb2d3d24c151268f192 100644
--- a/tools/binary_size/README.md
+++ b/tools/binary_size/README.md
@@ -11,6 +11,9 @@ symbol information parsed from a linker .map file.
### Example Usage:
+Note: Linux isn't fully supported yet so you should probably follow the
+Android instructions below.
+
# Android:
# Googlers:
gn gen out/Release --args='is_official_build=true symbol_level=1 is_chrome_branded=true target_os="android"'
@@ -111,4 +114,3 @@ Tracked in https://crbug.com/681694
1. More `diagnose_apk_bloat.py` features:
* Add more diff types (pak files, Java symbols, native symbols).
- * Support local builds for revs before supersize existed.
« no previous file with comments | « no previous file | tools/binary_size/diagnose_apk_bloat.py » ('j') | tools/binary_size/diagnose_apk_bloat.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698