Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2174)

Unified Diff: chrome/browser/signin/easy_unlock_service_signin_chromeos.cc

Issue 2847233003: [EasyUnlock] Move DataWithTimestamp out of ForegroundEidGenerator so it can be shared. (Closed)
Patch Set: fixes Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/signin/easy_unlock_service_signin_chromeos.cc
diff --git a/chrome/browser/signin/easy_unlock_service_signin_chromeos.cc b/chrome/browser/signin/easy_unlock_service_signin_chromeos.cc
index fc71efaa6848bfb8eb039ef278b3b3623ded45a0..73e4272c96d131c64fe45cfee99b682c107b9e84 100644
--- a/chrome/browser/signin/easy_unlock_service_signin_chromeos.cc
+++ b/chrome/browser/signin/easy_unlock_service_signin_chromeos.cc
@@ -428,25 +428,25 @@ void EasyUnlockServiceSignin::OnUserDataLoaded(
if (devices.empty())
return;
+ PA_LOG(WARNING) << "Loaded devices: " << devices.size();
+
cryptauth::RemoteDeviceList remote_devices;
for (const auto& device : devices) {
- std::string decoded_public_key, decoded_psk, decoded_challenge;
+ std::string decoded_public_key, decoded_psk;
if (!base::Base64UrlDecode(device.public_key,
base::Base64UrlDecodePolicy::REQUIRE_PADDING,
&decoded_public_key) ||
!base::Base64UrlDecode(device.psk,
base::Base64UrlDecodePolicy::REQUIRE_PADDING,
- &decoded_psk) ||
- !base::Base64UrlDecode(device.challenge,
- base::Base64UrlDecodePolicy::REQUIRE_PADDING,
- &decoded_challenge)) {
- PA_LOG(ERROR) << "Unable base64url decode stored remote device: "
- << device.public_key;
+ &decoded_psk)) {
+ PA_LOG(ERROR) << "Unable base64url decode stored remote device:\n "
+ << "public key: " << device.public_key << "\n"
+ << "psk: " << device.psk;
continue;
}
cryptauth::RemoteDevice remote_device(
account_id.GetUserEmail(), std::string(), decoded_public_key,
- device.bluetooth_address, decoded_psk, decoded_challenge);
+ device.bluetooth_address, decoded_psk, device.challenge);
remote_devices.push_back(remote_device);
PA_LOG(INFO) << "Loaded Remote Device:\n"
<< " user id: " << remote_device.user_id << "\n"

Powered by Google App Engine
This is Rietveld 408576698