[EasyUnlock] Move DataWithTimestamp out of ForegroundEidGenerator so it can be shared.

components/cryptauth/foreground_eid_generator.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_CRYPTAUTH_BLE_FOREGROUND_EID_GENERATOR_H_
 #define COMPONENTS_CRYPTAUTH_BLE_FOREGROUND_EID_GENERATOR_H_
 
 #include <memory>
 #include <string>
 #include <vector>
 
 #include "base/gtest_prod_util.h"
 #include "base/macros.h"
 #include "base/time/clock.h"
+#include "components/cryptauth/data_with_timestamp.h"
 
 namespace cryptauth {
 
 class BeaconSeed;
 class RawEidGenerator;
 struct RemoteDevice;
 
 // Generates ephemeral ID (EID) values that are broadcast for foreground BLE
 // advertisements in the ProximityAuth protocol.
 //
 // When advertising in foreground mode, we don't care about battery consumption
 // while advertising. We assume, however, that the scanning side is
 // battery-conscious, and is using hardware-based scanning.
 //
 // For the inverse of this model, in which advertising is battery-sensitive, see
 // BackgroundEidGenerator.
 //
 // A peripheral-role device advertises a 4-byte advertisement with two parts: a
 // 2-byte EID which is specific to the central-role device with which it intends
 // to communicate, and a 2-byte EID which is specific to the peripheral-role
 // device.
 //
 // This class uses EID seed values synced from the back-end to generate these
 // EIDs.
 //
 // See go/proximity-auth-ble-advertising.
 class ForegroundEidGenerator {
  public:
-  // Stores EID-related data and timestamps at which time this data becomes
-  // active or inactive.
-  struct DataWithTimestamp {
-    DataWithTimestamp(const std::string& data,
-                      const int64_t start_timestamp_ms,
-                      const int64_t end_timestamp_ms);
-    DataWithTimestamp(const DataWithTimestamp& other);
-
-    bool ContainsTime(const int64_t timestamp_ms) const;
-    std::string DataInHex() const;
-
-    const std::string data;
-    const int64_t start_timestamp_ms;
-    const int64_t end_timestamp_ms;
-  };
-
   // Data for both a current and adjacent EID. The current EID *must* be
   // supplied, but adjacent data may be null. Each EID consists of a 2-byte EID
   // value paired with the timestamp at which time this value becomes active or
   // inactive.
   struct EidData {
     enum AdjacentDataType { NONE, PAST, FUTURE };
 
     EidData(const DataWithTimestamp current_data,
             std::unique_ptr<DataWithTimestamp> adjacent_data);
     ~EidData();
 
     AdjacentDataType GetAdjacentDataType() const;
     std::string DataInHex() const;
 
     const DataWithTimestamp current_data;
     const std::unique_ptr<DataWithTimestamp> adjacent_data;
   };
 
   // The flag used to denote that a Bluetooth 4.0 device has sent an
   // advertisement. This flag indicates to the recipient that the sender cannot
   // act as both a central- and peripheral-role device simultaneously, so the
   // recipient should advertise back instead of initializing a connection.
   static const int8_t kBluetooth4Flag;
 
   ForegroundEidGenerator();
   virtual ~ForegroundEidGenerator();
 
   // Generates EID data for the given EID seeds to be used as a background scan
-  // filter. In the normal case, two DataWithTimestamp values are returned, one
-  // for each EID seed rotation period. If data has not been synced from the
+  // filter. In the normal case, two DataWithTimestamp values are returned,
+  // one for each EID seed rotation period. If data has not been synced from the

[Kyle Horimoto, 2017/04/30 03:17:46]

Please revert the change.

[Tim Song, 2017/05/01 22:23:38]

Done.

   // backend recently and EID seeds are unavailable, nullptr is returned.
   virtual std::unique_ptr<EidData> GenerateBackgroundScanFilter(
       const std::vector<BeaconSeed>& scanning_device_beacon_seeds) const;
 
   // Generates advertisement data for the given EID seeds. If data has not been
   // synced from the back-end recently and EID seeds are unavailable, nullptr is
   // returned.
   virtual std::unique_ptr<DataWithTimestamp> GenerateAdvertisement(
       const std::string& advertising_device_public_key,
       const std::vector<BeaconSeed>& scanning_device_beacon_seeds) const;
@@ skipping 95 matching lines @@
       CryptAuthForegroundEidGeneratorTest,
       GeneratePossibleAdvertisements_NoAdvertisements_SeedsTooFarInPast);
   FRIEND_TEST_ALL_PREFIXES(
       CryptAuthForegroundEidGeneratorTest,
       GeneratePossibleAdvertisements_NoAdvertisements_EmptySeeds);
 };
 
 }  // cryptauth
 
 #endif  // COMPONENTS_CRYPTAUTH_BLE_FOREGROUND_EID_GENERATOR_H_