chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer_unittest.cc - Issue 2847183002: predictors: Introduce GlowplugPredictor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer_unittest.cc

Issue 2847183002: predictors: Introduce GlowplugPredictor. (Closed)

Patch Set: GlowplugPredictor -> LoadingPredictor Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.cc ('k') | chrome/browser/precache/precache_manager_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer_unittest.cc

diff --git a/chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer_unittest.cc

index 02cc2d64022a85d515bfd9ed9cc2806fd8a11e9a..7cbfd20e9079b8b7ed3451147cdcd449566c4482 100644

--- a/chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer_unittest.cc

+++ b/chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer_unittest.cc

@@ -4,6 +4,8 @@

#include "chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.h"

+#include <memory>

#include "base/memory/ptr_util.h"

#include "chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h"

#include "chrome/browser/predictors/resource_prefetch_common.h"

@@ -17,7 +19,7 @@ using predictors::ResourcePrefetchPredictor;

class MockResourcePrefetchPredictor : public ResourcePrefetchPredictor {

public:

MockResourcePrefetchPredictor(

- const predictors::ResourcePrefetchPredictorConfig& config,

+ const predictors::LoadingPredictorConfig& config,

Profile* profile)

: ResourcePrefetchPredictor(config, profile) {}

@@ -31,8 +33,8 @@ class ResourcePrefetchPredictorPageLoadMetricsObserverTest

protected:

void SetUp() override {

page_load_metrics::PageLoadMetricsObserverTestHarness::SetUp();

- predictors::ResourcePrefetchPredictorConfig config;

- config.mode = predictors::ResourcePrefetchPredictorConfig::LEARNING;

+ predictors::LoadingPredictorConfig config;

+ config.mode = predictors::LoadingPredictorConfig::LEARNING;

predictor_ =

base::MakeUnique<testing::StrictMock<MockResourcePrefetchPredictor>>(

config, profile());