chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.cc - Issue 2847183002: predictors: Introduce GlowplugPredictor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.cc

Issue 2847183002: predictors: Introduce GlowplugPredictor. (Closed)

Patch Set: Address comments. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/BUILD.gn ('k') | chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer_unittest.cc » ('j') | chrome/browser/predictors/glowplug_config.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.cc

diff --git a/chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.cc

index eaa61a7ad4e2d7371ea8683acdaf7d58d3f1f43a..9044c2f13a0c2a5d0841843adbc1d8e0b25d8aca 100644

--- a/chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.cc

+++ b/chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.cc

@@ -4,10 +4,14 @@

#include "chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.h"

+#include <memory>

#include "base/memory/ptr_util.h"

#include "chrome/browser/page_load_metrics/page_load_metrics_util.h"

+#include "chrome/browser/predictors/glowplug_predictor.h"

+#include "chrome/browser/predictors/glowplug_predictor_factory.h"

#include "chrome/browser/predictors/resource_prefetch_predictor.h"

-#include "chrome/browser/predictors/resource_prefetch_predictor_factory.h"

+#include "chrome/browser/profiles/profile.h"

#include "content/public/browser/web_contents.h"

namespace internal {

@@ -25,13 +29,12 @@ const char kHistogramResourcePrefetchPredictorFirstMeaningfulPaint[] =

std::unique_ptr<ResourcePrefetchPredictorPageLoadMetricsObserver>

ResourcePrefetchPredictorPageLoadMetricsObserver::CreateIfNeeded(

content::WebContents* web_contents) {

- predictors::ResourcePrefetchPredictor* predictor =

- predictors::ResourcePrefetchPredictorFactory::GetForProfile(

- web_contents->GetBrowserContext());

- if (!predictor)

+ auto* glowplug = predictors::GlowplugPredictorFactory::GetForProfile(

+ Profile::FromBrowserContext(web_contents->GetBrowserContext()));

+ if (!glowplug)

return nullptr;

return base::MakeUnique<ResourcePrefetchPredictorPageLoadMetricsObserver>(

- predictor, web_contents);

+ glowplug->resource_prefetch_predictor(), web_contents);

}

ResourcePrefetchPredictorPageLoadMetricsObserver::